Closed Bug 459615 Opened 11 years ago Closed 11 years ago

Remove the needElevation param from WinLaunchChild

Categories

(Toolkit :: Startup and Profile System, defect)

x86
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file, 4 obsolete files)

This is now only used by PostUpdate in nsAppRunner.cpp which will be going away as soon as SeaMonkey's post update process has been updated and should be removed.
Attached patch patch (obsolete) — Splinter Review
Attached patch patch (obsolete) — Splinter Review
Attachment #344948 - Attachment is obsolete: true
Attachment #344950 - Flags: review?(ted.mielczarek)
Attachment #344950 - Flags: review?(jmathies)
Comment on attachment 344950 [details] [diff] [review]
patch

--- a/toolkit/mozapps/update/src/updater/updater.cpp
+  WCHAR *cmdline = (WCHAR *) malloc((len + 1) * sizeof(WCHAR));

You should probably free this pointer later just for cleanliness.

--- a/toolkit/xre/nsAppRunner.cpp
+    wcscat(cmdLine, secondArg);
+    wcscat(cmdLine, logFilePath.get());

Do we need to worry about quoting on logFilePath here?
Attachment #344950 - Flags: review?(ted.mielczarek) → review+
Attached patch patch rev2 (obsolete) — Splinter Review
Thanks Ted. The path doesn't need to be quoted due to the way the helper.exe parses the args.
Attachment #344950 - Attachment is obsolete: true
Attachment #346690 - Flags: review+
Attachment #344950 - Flags: review?(jmathies)
Attachment #346690 - Attachment is obsolete: true
Comment on attachment 346690 [details] [diff] [review]
patch rev2

bogus patch
Attached patch patch rev3 (obsolete) — Splinter Review
Attachment #346692 - Flags: review+
Attachment #346692 - Flags: review?(jmathies)
Attachment #346692 - Flags: review?(jmathies) → review+
Attachment #346692 - Attachment is obsolete: true
Attachment #355061 - Flags: review+
Pushed to mozilla-central
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Brad, after this was checked in the Windows Mobile builds broke with the following in the logs
Errors during apply, please fix and refresh bug_465874_env_vars
fatal error: The following error trigger was found: Errors during apply, please fix and refresh

It isn't clear to me why this would break Mobile or how to fix this based on the error so I am cc'ing you to the bug that appears to have caused it
You need to log in before you can comment on or make changes to this bug.