459651 - about:sessionrestore shouldn't list about:sessionrestore as single tab to restore

Status: VERIFIED FIXED

Description

[Ted Mielczarek [:ted.mielczarek]]

Created attachment 342855 [details]
confusing session restore page

If you crash, then restart Firefox and get the about:sessionrestore page, then wait a minute, and crash again, you can get about:sessionrestore to list about:sessionrestore as your tab from the previous session. Restoring this session brings up about:sessionrestore showing your tabs from two sessions ago. This is pretty confusing. We should just skip that step in the middle and offer to restore the original set of tabs.

Comment 1

[Simon Bünzli]

While we could unwrap crash states containing only about:sessionrestore, I'm not sure what to do when you open a new tab before crashing again. What would you expect in that case?

Comment 2

[Ted Mielczarek [:ted.mielczarek]]

I think if the user opens any other tabs or windows, then restoring the about:sessionrestore tab is a sane behavior. If there's only one tab in the session, however, and it contains about:sessionrestore, we should just get back to the original restore page.

Comment 3

[Simon Bünzli]

Created attachment 342909 [details] [diff] [review]
don't wrap a single about:sessionrestore page

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 342909 [details] [diff] [review]
don't wrap a single about:sessionrestore page

r=me. can you tuck all the "should restore?" determination code in a separate method?

Comment 5

[Simon Bünzli]

Created attachment 342923 [details] [diff] [review]
for check-in
[Checkin: Comment 6]

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 342923 [details] [diff] [review]
for check-in
[Checkin: Comment 6]

http://hg.mozilla.org/mozilla-central/rev/3f4d21c3af97

Comment 7

[Henrik Skupin (:whimboo)]

Sorry, but this still happens with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081017 Minefield/3.1b2pre ID:20081017020232

I can reproduce it by open about:sessionrestore and crashing the browser (e.g. by the use of the crash me extension). After the restart about:sessionrestore lists itself to be restored.

Comment 8

[Simon Bünzli]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081017 Minefield/3.1b2pre

This is fixed as expected. Note that you're still able to get about:sessionrestore listing itself when you had _other_ tabs or windows opened besides about:sessionrestore at the moment of the crash (cf. comment #2).

Comment 9

[Marcia Knous [:marcia - use ni]]

I can verify this fixed if I follow a different set of STR than Henrik does in Comment 7. If I crash the browser x2 and actually generate the about:sessionrestore page on its own and then crash again, when the browser restarts I do not see the about:sessionrestore listing listing that page. I am not sure if Henrik sees it because he explicitly entered it into the URL bar versus having it auto generated because of a crash.

Comment 10

[Henrik Skupin (:whimboo)]

Seems that this was the reason. I can't see it anymore.