Closed Bug 459765 Opened 11 years ago Closed 11 years ago

Update liboggplay_audio to latest code and new svn repository

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: cajbir, Assigned: cajbir)

References

Details

Attachments

(1 file, 1 obsolete file)

The audio library we're using for video/audio support has moved to a new svn repository, been renamed to libsydneyaudio, and has a number of fixes applied. Need to update to this to get fixes that Matthew Gregan has contributed for audio support:

http://trac.annodex.net/ticket/426
http://trac.annodex.net/ticket/427
http://trac.annodex.net/ticket/428
Attached patch Move to libsydneyaudio (obsolete) — Splinter Review
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
Attachment #342985 - Flags: review?
Attachment #342985 - Flags: review? → review?(kinetik)
Comment on attachment 342985 [details] [diff] [review]
Move to libsydneyaudio

The addition of libsydneyaudio to toolkit-tiers.mk
seems to be using spaces instead of tabs.  Otherwise looks good and builds and works for me on OS X.

Note that this patch doesn't include the fix for #426--it's not included upstream yet as the patch is still awaiting discussion/review.
Attachment #342985 - Flags: review?(kinetik) → review+
Think you could add a license header to media/libsydneyaudio/include/sydney_audio.h while you're at it? :)
I added the license header and upstreamed it to annodex's repository. Fixed the tab issue. That'll teach me to misconfigure vim.
Attachment #342985 - Attachment is obsolete: true
Depends on: 449159
Blocks: 449159
No longer depends on: 449159
http://hg.mozilla.org/mozilla-central/rev/e26faadf2c84
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in before you can comment on or make changes to this bug.