459769 - (Typo) In FormControlFilter() "HTMLTextareaElement" should be "HTMLTextAreaElement"

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Philip Chee]

From: <http://forums.mozillazine.org/viewtopic.php?p=4707595#p4707595>

[quote="asmpgmr"]
Minor bug when selecting any tab of Page Info for http://www.google.com/advanced_search - this only occurs the first time you select a tab other than the General tab

From the error console:

Error: uncaught exception: [Exception... "'[JavaScript Error: "HTMLTextareaElement is not defined" {file: "chrome://navigator/content/pageinfo/pageInfo.js" line: 677}]' when calling method: [nsIDOMNodeFilter::acceptNode]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: chrome://navigator/content/pageinfo/pageInfo.js :: findFirstControl :: line 687" data: yes]
Source File: chrome://navigator/content/pageinfo/pageInfo.js
Line: 481

Running SeaMonkey 2.0a2pre from Oct 10 on Win XP Pro SP2 with no extensions and the default theme.
[/quote]

[quote="asmpgmr"]
The page info bug I mentioned is due to a typo in file content\navigator\pageinfo\pageInfo.js in comm.jar, on line 677 HTMLTextareaElement should be HTMLTextAreaElement (note case). The affected function should be as follows:

Code: Select all
    function FormControlFilter(node)
    {
      if (node instanceof HTMLInputElement || node instanceof HTMLSelectElement ||
          node instanceof HTMLButtonElement || node instanceof HTMLTextAreaElement ||
          node instanceof HTMLObjectElement)
          return NodeFilter.FILTER_ACCEPT;
        return NodeFilter.FILTER_SKIP;
    }
[/quote]

Comment 1

[Philip Chee]

Attachment: Fix typo v1.0 [Checkin: Comment 2]

MXR case sensitive search says this is the only instance of this particular typo.

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 342982 [details] [diff] [review]
Fix typo v1.0
[Checkin: Comment 2]

http://hg.mozilla.org/comm-central/rev/35c0a4ffe962