Closed Bug 459769 Opened 11 years ago Closed 11 years ago

(Typo) In FormControlFilter() "HTMLTextareaElement" should be "HTMLTextAreaElement"

Categories

(SeaMonkey :: Page Info, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a2

People

(Reporter: philip.chee, Assigned: philip.chee)

Details

Attachments

(1 file)

From: <http://forums.mozillazine.org/viewtopic.php?p=4707595#p4707595>

[quote="asmpgmr"]
Minor bug when selecting any tab of Page Info for http://www.google.com/advanced_search - this only occurs the first time you select a tab other than the General tab

From the error console:

Error: uncaught exception: [Exception... "'[JavaScript Error: "HTMLTextareaElement is not defined" {file: "chrome://navigator/content/pageinfo/pageInfo.js" line: 677}]' when calling method: [nsIDOMNodeFilter::acceptNode]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: chrome://navigator/content/pageinfo/pageInfo.js :: findFirstControl :: line 687" data: yes]
Source File: chrome://navigator/content/pageinfo/pageInfo.js
Line: 481

Running SeaMonkey 2.0a2pre from Oct 10 on Win XP Pro SP2 with no extensions and the default theme.
[/quote]

[quote="asmpgmr"]
The page info bug I mentioned is due to a typo in file content\navigator\pageinfo\pageInfo.js in comm.jar, on line 677 HTMLTextareaElement should be HTMLTextAreaElement (note case). The affected function should be as follows:

Code: Select all
    function FormControlFilter(node)
    {
      if (node instanceof HTMLInputElement || node instanceof HTMLSelectElement ||
          node instanceof HTMLButtonElement || node instanceof HTMLTextAreaElement ||
          node instanceof HTMLObjectElement)
          return NodeFilter.FILTER_ACCEPT;
        return NodeFilter.FILTER_SKIP;
    }
[/quote]
MXR case sensitive search says this is the only instance of this particular typo.
Assignee: nobody → philip.chee
Attachment #342982 - Flags: superreview?(neil)
Attachment #342982 - Flags: review?(db48x)
Attachment #342982 - Flags: superreview?(neil)
Attachment #342982 - Flags: superreview+
Attachment #342982 - Flags: review?(db48x)
Attachment #342982 - Flags: review+
Keywords: checkin-needed
Attachment #342982 - Attachment description: Fix typo v1.0 → Fix typo v1.0 [Checkin: Comment 2]
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0a2
You need to log in before you can comment on or make changes to this bug.