459770 - Break out Access-Control code from nsXMLHttpRequest.cpp

Status: RESOLVED DUPLICATE of bug 644476

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

There is way too much Access-Control code in nsXMLHttpRequest.cpp. This makes both the AC implementation and nsXMLHttpRequest.cpp hard to read.

Patch attached that does the following:

Move all AC classes to nsCrossSiteListenerProxy.cpp (which should be renamed, i'll do that in a separate patch once the AC implementation is more stable).

Move the logic about when a preflight is needed from the nsXMLHttpRequest class to a static function in nsCrossSiteListenerProxy.

Move the code for setting preflight headers into the above static function since that is where we set up the rest of the preflight.

Make the nsACPreflightCache fully static and let it allocate its member as needed instead.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Fixes

Comment 2

[Serge Gautherie (:sgautherie)]

http://hg.mozilla.org/mozilla-central/rev/8ec9e2559693
http://hg.mozilla.org/mozilla-central/rev/db54bf3abf0d
{
Backed out changeset: 1a8fd714a794
Break out Access-Control code from nsXMLHttpRequest.cpp. r/sr=mrbkap b=459770
which leaks 280 kB.
}

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)

See
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1224197327.1224207154.24692.gz
Darwin 9.2.2 moz2-darwin8-slave02 dep unit test on 2008/10/16 15:48:47
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1224195941.1224199317.2344.gz
WINNT 5.2 mozilla-central moz2-win32-slave07 dep unit test on 2008/10/16 15:25:41
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1224196047.1224200710.5915.gz
WINNT 5.2 mozilla-central moz2-win32-slave08 dep unit test on 2008/10/16 15:27:27
+
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1224196343.1224201006.6503.gz
Linux comm-central dep unit test on 2008/10/16 15:32:23
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1224199507.1224205048.19887.gz
MacOSX 10.4 comm-central dep unit test on 2008/10/16 16:25:07
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1224195150.1224200190.4400.gz
Win2k3 comm-central dep unit test on 2008/10/16 15:12:30

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)

And Linux FF has is too, even if it's "masked" by bug 460382:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1224194594.1224199001.1393.gz&fulltext=1
Linux mozilla-central moz2-linux-slave07 dep unit test on 2008/10/16 15:03:14
TEST-PASS | runtests-leaks | no leaks detected!

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1224205981.1224209376.29096.gz&fulltext=1
Linux mozilla-central moz2-linux-slave07 dep unit test on 2008/10/16 18:13:01
TEST-PASS | runtests-leaks | WARNING leaked 296527 bytes during test execution

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Erm, Are you sure the leaks were caused by this patch? It seems very unlikely given the things that leaked and the changes made in the patch.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This was fixed in bug 644476