Closed Bug 459773 Opened 11 years ago Closed 11 years ago

Creating a collation is expensive

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file)

Not only is it expensive, but we don't need it until someone sorts by name.  No need to create it during startup.  See attachment 342988 [details] for profile data (3.4% of places startup is here).
Note:  the function GetCollation currently says it will not return null.  Now we could, but it's OK because the only caller checks to make sure it's not null anyway.
Attached patch v1.0Splinter Review
Attachment #342991 - Flags: review?(dietrich)
Whiteboard: [has patch][needs review dietrich]
Comment on attachment 342991 [details] [diff] [review]
v1.0

r=me
Attachment #342991 - Flags: review?(dietrich) → review+
Whiteboard: [has patch][needs review dietrich] → [has patch]
Whiteboard: [has patch] → [has patch][has review]
http://hg.mozilla.org/mozilla-central/rev/27cfa3904cdd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
You need to log in before you can comment on or make changes to this bug.