Closed
Bug 459773
Opened 17 years ago
Closed 17 years ago
Creating a collation is expensive
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
|
3.94 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Not only is it expensive, but we don't need it until someone sorts by name. No need to create it during startup. See attachment 342988 [details] for profile data (3.4% of places startup is here).
|
Assignee | |
Comment 1•17 years ago
|
||
Note: the function GetCollation currently says it will not return null. Now we could, but it's OK because the only caller checks to make sure it's not null anyway.
|
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #342991 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [has patch][needs review dietrich]
|
||
Comment 3•17 years ago
|
||
Comment on attachment 342991 [details] [diff] [review]
v1.0
r=me
Attachment #342991 -
Flags: review?(dietrich) → review+
|
|
||
Updated•17 years ago
|
Whiteboard: [has patch][needs review dietrich] → [has patch]
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [has patch] → [has patch][has review]
|
|
Assignee | |
Comment 4•17 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
You need to log in
before you can comment on or make changes to this bug.
Description
•