459777 - [zh-CN] search plugin, add wikipedia (zh) or modify current wikipedia (en) to (zh)

Status: RESOLVED FIXED

(Mozilla Localizations :: zh-CN / Chinese (Simplified), defect)

Description

[Shaohua Wen]

Now we are able to access wikipedia (zh) after the Olympic games.
maybe we should add wikipedia zh or modify the current en wikipedia search plugin to zh ?

Comment 1

[Shaohua Wen]

Attachment: patch for replace en with zh wikipedia

Comment 2

[Jack Guo]

Thank you Shaohua, this is great. Will this meet FF3.1 release schedule?

Comment 3

[Shaohua Wen]

If it's possible for ff 3.0.x , that would be great.
What do you think?
If that's too much for 3.0.x , we can add it for 3.1 only.

Comment 4

[Staś Małolepszy :stas]

Comment on attachment 342996 [details] [diff] [review]
patch for replace en with zh wikipedia

Taking this off from Axel's review queue.

We generally prefer using only the MozSearch namespace (it extends the OpenSearch format), so there's no need to use <os:.../>, which improves readability. Same for putting the URL parameters in the URL template: the preferred way is to use the <Param/> elements.

I suggest simply taking the en-US plug-in and changing the following lines:

>-<ShortName>Wikipedia (en)</ShortName>
>-<Description>Wikipedia, the free encyclopedia</Description>

>-<Url type="application/x-suggestions+json" method="GET" template="http://en.wikipedia.org/w/api.php">

>-<Url type="text/html" method="GET" template="http://en.wikipedia.org/wiki/Special:Search">

>-<SearchForm>http://en.wikipedia.org/wiki/Special:Search</SearchForm>

If we fix this this week, we should be able to make it both for 3.0.4 and 3.1 beta2.

Comment 5

[Shaohua Wen]

Attachment: patch for replace en with zh wikipedia

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 343018 [details] [diff] [review]
patch for replace en with zh wikipedia

r=me. Please commit the change to hg. For cvs, please wait for Axel's approval.

Thanks.

Comment 7

[Shaohua Wen]

changeset:  24:e9a981f58431
user/date:  [e-mail]	2008-10-14 08:30:34
parent:     23:65239c374d42 sync with en 10.12
tags:       tip

Comment 8

[Axel Hecht [:Pike]]

We generally refrain from changing our search set on a minor update channel, not sure if this would be a good exception. But from a user experience, I'd rather not, in particular in the light of our stricter rules for the stable branches now.

For 3.1, we still need a patch for removed-files.in to clear the en-CN one on major update, which I think we should do.

Comment 9

[Shaohua Wen]

Looks like that we also missed list.txt which need to be modified also.

Comment 10

[Axel Hecht [:Pike]]

Want to come up with a bustage-fix patch for list.txt?

Comment 11

[Shaohua Wen]

Attachment: bustage fix patch

Comment 12

[Staś Małolepszy :stas]

Ouch, sorry for missing that, my bad.

Comment 13

[Staś Małolepszy :stas]

Comment on attachment 343018 [details] [diff] [review]
patch for replace en with zh wikipedia

Per Axel's comment 8, cancelling the approval1.9.0.4 request.

Comment 14

[Shaohua Wen]

changeset:  25:f2487e2f19b9
user/date:  [e-mail]	2008-10-14 09:29:32
parent:     24:e9a981f58431  Bug 459777 -  [zh-CN] search plugin, add wikipedia (zh) or modify current wikipedia (en) to (zh) a=[e-mail]
tags:       tip

Comment 15

[Staś Małolepszy :stas]

Attachment: removed-files.in patch

Per comment 8: Axel, is this correct?

Also, out of curiosity: why did we have a en-CN file in the first place (instead of putting en-US wikipedia in list.txt)?

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 343032 [details] [diff] [review]
removed-files.in patch

r=me.

The reason we used wikipedia-en-CN.xml is exactly to be able to create this patch. We can only remove particularly named files in all localized builds. So using a name that isn't precise to specify the xml we shipped with zh-CN could lead us into trouble somewhere down the road.

Requesting review from Nick, too, he's our removing overlord.

Comment 17

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 343032 [details] [diff] [review]
removed-files.in patch

/me smiles benevolently.

(In reply to comment #8)
> For 3.1, we still need a patch for removed-files.in to clear the en-CN one on
> major update, which I think we should do.

This will affect minor updates for 3.1b1 onwards too, but that seems fine to me.

Comment 18

[Axel Hecht [:Pike]]

Taking this bug so that I know it's on my radar to actually land this.

Comment 19

[Axel Hecht [:Pike]]

... "this" being the change to removed-files.in. Moving over to the Firefox product so that I get some flags.

Comment 20

[Axel Hecht [:Pike]]

Comment on attachment 343032 [details] [diff] [review]
removed-files.in patch

This is a follow up landing to actually remove the cn-only version of en.wikipedia.org we used to ship. This is an anticipated change, and as such, really low risk.

Comment 21

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 343032 [details] [diff] [review]
removed-files.in patch

a191=beltzner

Comment 22

[Axel Hecht [:Pike]]

http://hg.mozilla.org/mozilla-central/rev/6f34b3d7748d and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/617e310fa0aa, marking FIXED and fixed1.9.1.

Moving back into the Mozilla Localizations, too.