459820 - Need automated tests for Caps Lock key events

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

spun off from bug 457523.

We need automated tests for Caps Lock key. The patch is coming soon.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

I added keydown/keyup testing code.

We have two issues:

1. Only on Windows, the modifier keydown/keyup events are fired from syntesizeNativeKeyEvent. So, this patch needs to ignore the key events. It seems that Mac should fire these events too.

2. The key up events are not fired on Mac when Command key is pressed.

But these issues should be out of scope of this bug.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+  const SHOULD_DELIVED_NONE         = 0x0;
+  const SHOULD_DELIVED_KEYDOWN      = 0x1;
+  const SHOULD_DELIVED_KEYPRESS     = 0x2;
+  const SHOULD_DELIVED_KEYUP        = 0x4;
+  const SHOULD_DELIVED_ALL          = SHOULD_DELIVED_KEYDOWN |
+                                      SHOULD_DELIVED_KEYPRESS |
+                                      SHOULD_DELIVED_KEYUP;

I think DELIVED is meant to be DELIVER.

+  const SHOULD_NOT_DELIVED_KEYPRESS = SHOULD_DELIVED_KEYDOWN |
+                                      SHOULD_DELIVED_KEYUP;
+  const SHOULD_NOT_DELIVED_KEYUP    = SHOULD_DELIVED_KEYDOWN |
+                                      SHOULD_DELIVED_KEYPRESS;

I wouldn't use NOT. I'd just say SHOULD_DELIVER_KEYDOWN_KEYUP and SHOULD_DELIVER_KEYDOWN_KEYPRESS.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.1

renamed them.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 343178 [details] [diff] [review]
Patch v1.1

Thanks!!

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.