Closed Bug 459934 Opened 12 years ago Closed 11 years ago
should lazy-load places autocomplete statements
<sdwilsh> dietrich: so, it might be worthwhile to make lazy getters for all the location bar queries <sdwilsh> it's still 20.4% of our startup time <sdwilsh> and some of them we may never use <sdwilsh> (the special search ones) <sdwilsh> those should at least be made lazy
Attachment #343249 - Flags: review?(dietrich) → review+
Comment on attachment 343249 [details] [diff] [review] patch per irc, move the helper to a global var. r=me otherwise. also, please add a comment about why we're not lazy loading the other queries.
Comment on attachment 343287 [details] [diff] [review] patch r=sdwilsh
Attachment #343287 - Flags: review?(sdwilsh) → review+
previous one was completely wrong
Attachment #343287 - Attachment is obsolete: true
Comment on attachment 343540 [details] [diff] [review] leak fix mpa=mano for landing with post facto review from dietrich.
Attachment #343540 - Flags: review?(mano) → review+
thanks, will post an updated patch with leak fix merged and ask for dietrich's review
this one is the merge of original patch with leak fix, plus a static cast that Shawn said is needed for gcc compile. asking final review for the leak fix, this has been tested in previous landing and was working correctly.
Attachment #343708 - Flags: review?(dietrich) → review+
Comment on attachment 343708 [details] [diff] [review] merged patch (patch + leak fix + static cast) r=me
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.