Closed Bug 459934 Opened 12 years ago Closed 12 years ago

should lazy-load places autocomplete statements

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: dietrich, Assigned: mak)

References

Details

Attachments

(1 file, 4 obsolete files)

<sdwilsh> dietrich: so, it might be worthwhile to make lazy getters for all the location bar queries
<sdwilsh> it's still 20.4% of our startup time
<sdwilsh> and some of them we may never use
<sdwilsh> (the special search ones)
<sdwilsh> those should at least be made lazy
Assignee: dietrich → mak77
Attached patch patch (obsolete) — Splinter Review
Attachment #343249 - Flags: review?(dietrich)
Attachment #343249 - Flags: review?(dietrich) → review+
Comment on attachment 343249 [details] [diff] [review]
patch

per irc, move the helper to a global var. r=me otherwise.

also, please add a comment about why we're not lazy loading the other queries.
Attached patch patch (obsolete) — Splinter Review
Attachment #343249 - Attachment is obsolete: true
Attachment #343287 - Flags: review?(sdwilsh)
Comment on attachment 343287 [details] [diff] [review]
patch

r=sdwilsh
Attachment #343287 - Flags: review?(sdwilsh) → review+
Attached patch patch (obsolete) — Splinter Review
previous one was completely wrong
Attachment #343287 - Attachment is obsolete: true
Attachment #343287 - Flags: review+
Attached patch leak fix (obsolete) — Splinter Review
Attachment #343540 - Flags: review?(mano)
Comment on attachment 343540 [details] [diff] [review]
leak fix

mpa=mano for landing with post facto review from dietrich.
Attachment #343540 - Flags: review?(mano) → review+
thanks, will post an updated patch with leak fix merged and ask for dietrich's review
this one is the merge of original patch with leak fix, plus a static cast that Shawn said is needed for gcc compile.

asking final review for the leak fix, this has been tested in previous landing and was working correctly.
Attachment #343302 - Attachment is obsolete: true
Attachment #343540 - Attachment is obsolete: true
Attachment #343708 - Flags: review?(dietrich)
Attachment #343708 - Flags: review?(dietrich) → review+
Comment on attachment 343708 [details] [diff] [review]
merged patch (patch + leak fix + static cast)

r=me
http://hg.mozilla.org/mozilla-central/rev/f8d94c2557ea
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.