459934 - should lazy-load places autocomplete statements

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Dietrich Ayala (:dietrich)]

<sdwilsh> dietrich: so, it might be worthwhile to make lazy getters for all the location bar queries
<sdwilsh> it's still 20.4% of our startup time
<sdwilsh> and some of them we may never use
<sdwilsh> (the special search ones)
<sdwilsh> those should at least be made lazy

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 343249 [details] [diff] [review]
patch

per irc, move the helper to a global var. r=me otherwise.

also, please add a comment about why we're not lazy loading the other queries.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 343287 [details] [diff] [review]
patch

r=sdwilsh

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch

previous one was completely wrong

Comment 6

[Marco Bonardo [:mak]]

Attachment: leak fix

Comment 7

[Asaf Romano (gone)]

Comment on attachment 343540 [details] [diff] [review]
leak fix

mpa=mano for landing with post facto review from dietrich.

Comment 8

[Marco Bonardo [:mak]]

thanks, will post an updated patch with leak fix merged and ask for dietrich's review

Comment 9

[Marco Bonardo [:mak]]

Attachment: merged patch (patch + leak fix + static cast)

this one is the merge of original patch with leak fix, plus a static cast that Shawn said is needed for gcc compile.

asking final review for the leak fix, this has been tested in previous landing and was working correctly.

Comment 10

[Dietrich Ayala (:dietrich)]

Comment on attachment 343708 [details] [diff] [review]
merged patch (patch + leak fix + static cast)

r=me

Comment 11

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/f8d94c2557ea