Polish about:sessionrestore

VERIFIED FIXED in Firefox 3.1b2

Status

()

VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: faaborg, Assigned: zeniko)

Tracking

Trunk
Firefox 3.1b2
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
Here are a few polish changes to the about:sessionrestore page:

1) Use native checkbox widgets in the restore column (might need to file a separate widget bug to get this working).

2) Instead of using a folder icon for each window, use a generic window icon, which you might need to copy over to toolkit

http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/preferences/application-aero.png
http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/preferences/application.png

I'll need to get you window icons for OS X and Linux (basically take the Tango new window icon and remove the star)

3) Update the text of the window

Since there is a large question icon, the title should ask a question

Would You Like to Restore Your Session?

------------------------------------
We sincerely apologize for the inconvenience. You can restore the tabs and windows from your previous session, or start a new session if they are no longer needed. 
------------------------------------
If Minefield closes repeatedly:
   * Try disabling any recently added extensions in the Add-ons Manager.
   * Try restoring your session without any Web pages you suspect might be causing the problem.

4) remove the line "uncheck the tabs that you don't want to restore" this should be apparent from the interface.
(Reporter)

Comment 1

10 years ago
Also, let's remove the "#" in the window name, so just "Window 1"
(Assignee)

Comment 2

10 years ago
(In reply to comment #0)
> 1) Use native checkbox widgets in the restore column (might need to file a
> separate widget bug to get this working).

Please do so.

> 2) Instead of using a folder icon for each window, use a generic window icon,
> which you might need to copy over to toolkit

Shouldn't this rather happen during the theme refresh scheduled for Firefox 3.1?

> 3) Update the text of the window

> Would You Like to Restore Your Session?
> ------------------------------------
> We sincerely apologize for the inconvenience. You can restore the tabs and
> windows from your previous session, or start a new session if they are no
> longer needed. 
> ------------------------------------

With this, you lose the information about _why we display this page in the first place_ (Firefox closed unexpectedly). That's hopefully not intentional.

> 4) remove the line "uncheck the tabs that you don't want to restore"

You're still using my extension and not the feature as it landed. That line has been gone for quite a while.
(Reporter)

Comment 3

10 years ago
>With this, you lose the information about _why we display this page in the
>first place_ (Firefox closed unexpectedly). That's hopefully not intentional.

After watching Firefox crash, and then interacting with crash reporter, isn't it reasonably obvious that Firefox closed unexpectedly?  Perhaps:

"Firefox Closed Unexpectedly. Would you Like to Restore your Session?"

>> 4) remove the line "uncheck the tabs that you don't want to restore"
>
>You're still using my extension and not the feature as it landed. That line has
>been gone for quite a while.

Sorry about that, I didn't realize the extension was still enabled.
(Assignee)

Comment 4

10 years ago
(In reply to comment #3)
> After watching Firefox crash, and then interacting with crash reporter, isn't
> it reasonably obvious that Firefox closed unexpectedly?

Not if you don't restart Firefox for a few hours after a crash (i.e. not for people who get annoyed or don't care and come back later on).

> "Firefox Closed Unexpectedly. Would you Like to Restore your Session?"

That won't fit on the title line any longer (and would be somewhat heavy as a title). What about:

"Restore Crashed Session?" (also as the tab's title)

and then start with

"Your previous Firefox session closed unexpectedly. We sincerely apologize for the inconvenience. ..."
(Reporter)

Comment 5

10 years ago
what do you think of:

 Would You Like to Restore Your Session?
 ------------------------------------
Your previous Firefox session closed unexpectedly. We sincerely apologize for the inconvenience. You can restore the tabs and  windows from your previous session, or start a new session if they are no  longer needed. 
 ------------------------------------

The tab title would be "Restore Session"

I agree that we need to say that Firefox closed unexpectedly somewhere, although since most of the time people probably saw it happen, I think it is ok to lead with just the direct question.  We usually try to avoid saying the word "crash" since it is slightly into the realm of jargon (although not nearly as bad as some other terms).
(Assignee)

Comment 6

10 years ago
Created attachment 344824 [details] [diff] [review]
text update

This updates the text to comment #5 and fixes the l10n note.
Attachment #344824 - Flags: review?(l10n)
(Assignee)

Updated

10 years ago
Depends on: 448976

Comment 7

10 years ago
restorepage.dueToContent still talks about crash, is that intentional?

I'm leaning towards a localization note of "crash" vs. "ended unexpectedly". Just in case that "ended unexpectedly" sounds so awkward in a localization that just saying "crash" or a different phrase is the better compromise.
(Reporter)

Comment 8

10 years ago
Yeah, saying crash is fine if "closed unexpectedly" will be very strange.  Also (and I have no idea if this is actually the case) I imagine some locals could theoretically use a specific term or phrase to represent a crashing application.
(Assignee)

Comment 9

10 years ago
Created attachment 344845 [details] [diff] [review]
like so?

(In reply to comment #7)
> restorepage.dueToContent still talks about crash, is that intentional?

No, I just missed Alex correcting it to "problem".
Attachment #344824 - Attachment is obsolete: true
Attachment #344845 - Flags: review?(l10n)
Attachment #344824 - Flags: review?(l10n)

Comment 10

10 years ago
Comment on attachment 344845 [details] [diff] [review]
like so?

I'd like to get Alex' review on the localization notes, too.

Reading the text, I wonder if "you suspect might be causing the problem" should rather be "triggered". I lack native language skills if that'd be too picky.
Attachment #344845 - Flags: review?(l10n)
Attachment #344845 - Flags: review?(faaborg)
Attachment #344845 - Flags: review+
(Assignee)

Comment 11

10 years ago
Comment on attachment 344845 [details] [diff] [review]
like so?

Alex: This Friday is L10n freeze, so please review this patch ASAP as I'll also have to find somebody to check it in for me before it's too late.
(Reporter)

Comment 12

10 years ago
Comment on attachment 344845 [details] [diff] [review]
like so?

Looks good, sorry about the lag.
Attachment #344845 - Flags: review?(faaborg) → ui-review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed

Comment 13

10 years ago
Pushed to mozilla-central: <http://hg.mozilla.org/mozilla-central/rev/0e702acc89d9>
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2

Updated

10 years ago
Assignee: nobody → zeniko
(Assignee)

Comment 14

10 years ago
Alex: Do you want to file new bugs about issues #1 and #2 or shall I REOPEN this one?
Comment 2 seems to not have been addressed on the mac using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081030 Minefield/3.1b2pre, but looks okay on Windows XP. Should I file a separate bug to track that issue?
(Reporter)

Comment 16

10 years ago
>Alex: Do you want to file new bugs about issues #1 and #2 or shall I REOPEN
>this one?

Sure, filed bug 462618 for XUL trees and bug 462619 for the window icons.
(Assignee)

Updated

10 years ago
Depends on: 462619
(Reporter)

Comment 17

10 years ago
Comment on attachment 344845 [details] [diff] [review]
like so?

forgot to reply to the comment on localization notes.

>If "closed unexpectedly" sounds too awkward in the translation,
+                        you may translate "crash" instead (even though it's IT-speak) 

That sounds fine.
verified fixed using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081103 Minefield/3.1b2pre, Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081103 Minefield/3.1b2pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081103 Minefield/3.1b2pre.
Status: RESOLVED → VERIFIED

Updated

10 years ago
Depends on: 464155

Updated

10 years ago
Blocks: 486461
You need to log in before you can comment on or make changes to this bug.