460012 - Firefox 3.1b1 :before and :after wackiness

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Kroc Camen]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1) Gecko/20081007 Firefox/3.1b1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1) Gecko/20081007 Firefox/3.1b1

Firstly, yes I assume that because 3.1 is beta, this may not need to be reported.
I'm experiencing some broken behaviour with :before and :after.

Reproducible: Always

Steps to Reproduce:
1. Visit camendesign.com
2. Mouse over:
i. The tag list on the left
ii. The blue tags on the right 
3. Watch results (the bullet points and count numbers for the tags are done with :after and :before)
Actual Results:  
* The tags spasm about
* For the tags on the right, if you mouse enter from above, they show the correct arrow - if you mouse enter from the side, the :before appears after!

Expected Results:  
See website in Firefox 3.0,
When you mouse over a tag, the bullet changes to an arrow. There is no movement of the text

Comment 1

[philippe (part-time)]

This regressed bewteen:
Gecko/20080817040141 Minefield/3.1a2pre (ok)
and
Gecko/20080818032051 Minefield/3.1a2pre (fails)

Likely from bug 238072

Comment 2

[philippe (part-time)]

Attachment: test case, minimised from url

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: minimized testcase that also shows text movement

I just readded the text alignment that's necessary to show the text movement.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #0)
> Firstly, yes I assume that because 3.1 is beta, this may not need to be
> reported.
> I'm experiencing some broken behaviour with :before and :after.

No, I think you're the first person who reported this, which means we might not otherwise have known it was a problem.  (If we did know about it, it would be in Bugzilla somewhere.)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Simpler testcase

Click on the green-bordered body. The X should change to a Y and keep its border, but instead it stays X and loses the border. If you zoom, it changes to a Y with a red border, indicating that rebuilding the style data and reflowing fixes the bug.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Mmm ... we seem to be getting a RecreateFramesForContent call on the anonymous XML :after node! That's not going to work.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

When we recreate frames for a generated content node, we should reframe the nearest non-generated-content ancestor.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 346418 [details] [diff] [review]
fix

Looks reasonable.  I assume this reframe is coming from ReResolveStyleContext followed by processing the restyle list?

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yep.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Er, maybe I'm not sure what you meant. We get this reframe directly from restyling; the change of 'content' on the :after node seems to directly turn into a framechange hint for the anonymous XML container for the :after content.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed on mozilla-central (and thus also on mozilla-1.9.1):
http://hg.mozilla.org/mozilla-central/rev/50eecdcfa91f

Comment 12

[Kroc Camen]

This is still present in Firefox 3.1 Beta 2. (See camendesign.com)
Did this fix not make it into Beta 2?
If it did, then the bug should be re-opened. The lists are still twitching about on mouse over, and now the :hover:before/after isn't being applied.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This bug is fixed on trunk, i.e. in nightly builds. Beta2 is a couple of weeks old already. The fix will be in the next beta.

Comment 14

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090407 Shiretoko/3.5b4pre ID:20090407031108

and 

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090406 Minefield/3.6a1pre ID:20090406035346