460065 - geolocation: no error reported to page when user disallows the API use

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Current trunk build

STEPS TO REPRODUCE: Run the javascript: URI in the URL field

EXPECTED RESULTS: Since no geolocation providers are installed, the error reporter function is called with a PositionError which has code == 1 and a reasonable message.

ACTUAL RESULTS: The error reporter function is not called at all.

This needs to be fixed before ship; as written we fail to return from the asynchronous request, which can essentially hang a web app that is waiting for us to return _something_ and blocking all actions in the meantime.

Comment 1

[Doug Turner (:dougt)]

i have fixed this in bug 455327.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Indeed.

Comment 3

[Doug Turner (:dougt)]

455327 landed.

Comment 4

[Doug Turner (:dougt)]

removing blocking1.9.1 flag.  bz -- this actually landed on 1.9.1 either before
we created the 1.9.1 branch or sometime there after.  in either case, 1.9.1
_has_ this fix.

Comment 5

[Boris Zbarsky [:bzbarsky]]

See bug 459893 comment 19.  Doesn't really matter, but the right thing to do in these cases is to set the flag (+ or -), not to just clear it.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

(restoring flag)

Comment 7

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a087bc8963b3