move moz2 unittest staging builds into mozilla2-staging buildbot

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
10 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: lsblakk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments, 2 obsolete attachments)

(Reporter)

Description

10 years ago
Created attachment 343258 [details] [diff] [review]
unittest and builds in the same master

Basically, this is a copy of the Buildbot configs running on staging-master:/builds/buildbot/hg-unittest-master (note that this is locally patched from the mozilla2-unittest configs).

I've modified the steps slightly to checkout mozconfigs from the new location, not run an HgPoller of its own, etc.

The mozconfigs have been made as consistent as the dep/nightly ones as possible.
The Builders have been renamed to be consistent with their dep/nightly/leak test counterparts.
The soon-to-be-created slaves have been added to the slavelists for dep/nightly/leak test + unittest builds.
The commented out win32 builder has been completely removed.

Most importantly, unittests will now be run on the same master as the rest of our builds.

I think that's everything. It's a big looking patch, but the bulk of unittest_master.cfg is unchanged.

Lukas, I'm mainly asking you for review to make sure I haven't accidentally tossed away any of the important local changes. (Though I don't think I tossed any of them away at all).
Attachment #343258 - Flags: review?(lukasblakk)
Attachment #343258 - Flags: review?(ccooper)

Updated

10 years ago
Attachment #343258 - Flags: review?(ccooper) → review+
(Assignee)

Comment 1

10 years ago
Comment on attachment 343258 [details] [diff] [review]
unittest and builds in the same master

Just add more slaves, up to slave18 on linux and win32.
Attachment #343258 - Flags: review?(lukasblakk) → review+
(Assignee)

Comment 2

10 years ago
So, let's also add bm-xserve22 to the Mac list
(Reporter)

Comment 3

10 years ago
Created attachment 343454 [details] [diff] [review]
[checked in] add moz2-{linux,win32}-slave{15,16,17,18} and bm-xserve22

changeset:   422:cb3b8ba6c989
Attachment #343258 - Attachment is obsolete: true
(Reporter)

Comment 4

10 years ago
Over to Lukas for slave setup.
Assignee: bhearsum → lukasblakk
(Reporter)

Comment 5

10 years ago
Created attachment 343914 [details] [diff] [review]
[checked in] follow-up to fix on-change traceback

Turns out I forgot to import isHgPollerTriggered, and used config instead of nightly_config.
Attachment #343914 - Flags: review?(ccooper)

Updated

10 years ago
Attachment #343914 - Flags: review?(ccooper) → review+
(Reporter)

Comment 6

10 years ago
Comment on attachment 343914 [details] [diff] [review]
[checked in] follow-up to fix on-change traceback

changeset:   424:6fe13c512ae4
Attachment #343914 - Attachment description: follow-up to fix on-change traceback → [checked in] follow-up to fix on-change traceback
(Assignee)

Updated

10 years ago
Depends on: 461147
(Reporter)

Comment 7

10 years ago
Created attachment 345297 [details] [diff] [review]
[checked in] enable existing staging slaves in unittest pool
Attachment #345297 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #345297 - Flags: review? → review+
(Reporter)

Updated

10 years ago
Attachment #345297 - Attachment description: enable existing staging slaves in unittest pool → [checked in] enable existing staging slaves in unittest pool
Attachment #345297 - Flags: review+ → review?
(Reporter)

Updated

10 years ago
Attachment #345297 - Flags: review? → review+
(Reporter)

Comment 8

10 years ago
Created attachment 345300 [details] [diff] [review]
bustage fix for unittest_master.py - copy the mozconfig from the right place
Attachment #345300 - Flags: review?(ccooper)

Updated

10 years ago
Attachment #345300 - Flags: review?(ccooper) → review+
(Reporter)

Comment 9

10 years ago
Just noticed on moz2-win32-slave04 that I had to agree to the pskill license the first time a build run. This should be done on _all_ of windows slaves before we run them through buildbot.
(Assignee)

Updated

10 years ago
Depends on: 458414
(Assignee)

Comment 10

10 years ago
My bad, I accepted as Admin on all of them...They are now all accepted as cltbld.

(In reply to comment #9)
> Just noticed on moz2-win32-slave04 that I had to agree to the pskill license
> the first time a build run. This should be done on _all_ of windows slaves
> before we run them through buildbot.
(Assignee)

Updated

10 years ago
Priority: -- → P2
Created attachment 346508 [details] [diff] [review]
set flunkOnFailure=False for unittest
Created attachment 346684 [details] [diff] [review]
[checked in] set flunkOnFailure=False for unittest
Attachment #346508 - Attachment is obsolete: true
(Reporter)

Comment 13

10 years ago
Comment on attachment 346684 [details] [diff] [review]
[checked in] set flunkOnFailure=False for unittest 

changeset:   492:8c675383696e
Attachment #346684 - Attachment description: set flunkOnFailure=False for unittest → [checked in] set flunkOnFailure=False for unittest
Attachment #346684 - Flags: review+
(Assignee)

Comment 14

10 years ago
Created attachment 346761 [details] [diff] [review]
check out mozconfig with cvs, not hg

Was talking with joduinn and for now, until these are working smoothly, we should keep the steps the same as they are on the unittest master, so checking out mozconfig with cvs instead of hg for now.
Attachment #346761 - Flags: review?(bhearsum)
(Reporter)

Updated

10 years ago
Attachment #346761 - Flags: review?(bhearsum) → review-
(Reporter)

Comment 15

10 years ago
Comment on attachment 346761 [details] [diff] [review]
check out mozconfig with cvs, not hg

As part of merging the unittests with the regular builds we should be pulling the mozconfigs from the same place IMHO.

Let's keep the mozconfigs in sync, yes, but pulling them from HG is the right thing to do and it's not going to cause any mysterious failures.
(Reporter)

Updated

10 years ago
Attachment #346684 - Flags: checked‑in+
(Assignee)

Updated

10 years ago
Blocks: 464079
Created attachment 349244 [details] [diff] [review]
Fix reload problems
Attachment #349244 - Flags: review?(bhearsum)
(Reporter)

Updated

10 years ago
Attachment #349244 - Flags: review?(bhearsum) → review+
(Reporter)

Comment 17

10 years ago
Comment on attachment 349244 [details] [diff] [review]
Fix reload problems

Checking in steps.py;
/cvsroot/mozilla/tools/buildbotcustom/unittest/steps.py,v  <--  steps.py
new revision: 1.15; previous revision: 1.14
done
(Reporter)

Updated

10 years ago
Attachment #349244 - Flags: checked‑in+
(Assignee)

Updated

10 years ago
No longer blocks: 464079
Depends on: 464079
So I think it's time to close this, mozilla2-staging buildbot is running fine and the standalone staging for unittest has been turned off.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.