Closed Bug 460077 Opened 14 years ago Closed 14 years ago

move moz2 unittest staging builds into mozilla2-staging buildbot

Categories

(Release Engineering :: General, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: lsblakk)

References

Details

Attachments

(7 files, 2 obsolete files)

Basically, this is a copy of the Buildbot configs running on staging-master:/builds/buildbot/hg-unittest-master (note that this is locally patched from the mozilla2-unittest configs).

I've modified the steps slightly to checkout mozconfigs from the new location, not run an HgPoller of its own, etc.

The mozconfigs have been made as consistent as the dep/nightly ones as possible.
The Builders have been renamed to be consistent with their dep/nightly/leak test counterparts.
The soon-to-be-created slaves have been added to the slavelists for dep/nightly/leak test + unittest builds.
The commented out win32 builder has been completely removed.

Most importantly, unittests will now be run on the same master as the rest of our builds.

I think that's everything. It's a big looking patch, but the bulk of unittest_master.cfg is unchanged.

Lukas, I'm mainly asking you for review to make sure I haven't accidentally tossed away any of the important local changes. (Though I don't think I tossed any of them away at all).
Attachment #343258 - Flags: review?(lukasblakk)
Attachment #343258 - Flags: review?(ccooper)
Attachment #343258 - Flags: review?(ccooper) → review+
Comment on attachment 343258 [details] [diff] [review]
unittest and builds in the same master

Just add more slaves, up to slave18 on linux and win32.
Attachment #343258 - Flags: review?(lukasblakk) → review+
So, let's also add bm-xserve22 to the Mac list
changeset:   422:cb3b8ba6c989
Attachment #343258 - Attachment is obsolete: true
Over to Lukas for slave setup.
Assignee: bhearsum → lukasblakk
Turns out I forgot to import isHgPollerTriggered, and used config instead of nightly_config.
Attachment #343914 - Flags: review?(ccooper)
Attachment #343914 - Flags: review?(ccooper) → review+
Comment on attachment 343914 [details] [diff] [review]
[checked in] follow-up to fix on-change traceback

changeset:   424:6fe13c512ae4
Attachment #343914 - Attachment description: follow-up to fix on-change traceback → [checked in] follow-up to fix on-change traceback
Depends on: 461147
Attachment #345297 - Flags: review? → review+
Attachment #345297 - Attachment description: enable existing staging slaves in unittest pool → [checked in] enable existing staging slaves in unittest pool
Attachment #345297 - Flags: review+ → review?
Attachment #345297 - Flags: review? → review+
Attachment #345300 - Flags: review?(ccooper) → review+
Just noticed on moz2-win32-slave04 that I had to agree to the pskill license the first time a build run. This should be done on _all_ of windows slaves before we run them through buildbot.
Depends on: 458414
My bad, I accepted as Admin on all of them...They are now all accepted as cltbld.

(In reply to comment #9)
> Just noticed on moz2-win32-slave04 that I had to agree to the pskill license
> the first time a build run. This should be done on _all_ of windows slaves
> before we run them through buildbot.
Priority: -- → P2
Comment on attachment 346684 [details] [diff] [review]
[checked in] set flunkOnFailure=False for unittest 

changeset:   492:8c675383696e
Attachment #346684 - Attachment description: set flunkOnFailure=False for unittest → [checked in] set flunkOnFailure=False for unittest
Attachment #346684 - Flags: review+
Was talking with joduinn and for now, until these are working smoothly, we should keep the steps the same as they are on the unittest master, so checking out mozconfig with cvs instead of hg for now.
Attachment #346761 - Flags: review?(bhearsum)
Attachment #346761 - Flags: review?(bhearsum) → review-
Comment on attachment 346761 [details] [diff] [review]
check out mozconfig with cvs, not hg

As part of merging the unittests with the regular builds we should be pulling the mozconfigs from the same place IMHO.

Let's keep the mozconfigs in sync, yes, but pulling them from HG is the right thing to do and it's not going to cause any mysterious failures.
Attachment #346684 - Flags: checked‑in+
Blocks: 464079
Attachment #349244 - Flags: review?(bhearsum)
Attachment #349244 - Flags: review?(bhearsum) → review+
Comment on attachment 349244 [details] [diff] [review]
Fix reload problems

Checking in steps.py;
/cvsroot/mozilla/tools/buildbotcustom/unittest/steps.py,v  <--  steps.py
new revision: 1.15; previous revision: 1.14
done
Attachment #349244 - Flags: checked‑in+
No longer blocks: 464079
Depends on: 464079
So I think it's time to close this, mozilla2-staging buildbot is running fine and the standalone staging for unittest has been turned off.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.