460155 - update <video> control icons

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[skierpage]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081015 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081015 Minefield/3.1b2pre ID:20081015032107

The images for the video controls, e.g. on http://www.double.co.nz/video_test/events.html, should be improved to match the accepted iconography of audio equipment.

Reproducible: Always

Steps to Reproduce:
1. Go to a page with video controls, or view chrome://global/skin/media/videocontrols.png
2. Run a screen magnifier like Windows' magnify.exe

Actual Results:  
The pause bars are slightly too tall.

The volume control speaker isn’t quite right, the voice coil on the back has rounded back corners (a voice coil has a squared off edge) and the coil is slightly too big for that size cone.



I earlier provided this feedback on http://jboriss.wordpress.com/2008/09/19/html-5-video-tag-pirate-edition/#comment-318 , along with comments on other parts of the control UI that aren't exposed (yet?).

Comment 1

[skierpage]

I adjusted the pause and the voice coil in http://www.skierpage.com/moz_bugs/videocontrols_tweaked.png , go back/forwards between it and chrome://global/skin/media/videocontrols.png to see the improvements.

Unfortunately, #$@! MS Paint changed the color balance (what tool do you use to edit PNGs?), so it's not a replacement.

Comment 2

[Jennifer Morrow [:Boriss] (UX)]

Thanks for the feedback, skierpage.  I'll revisit this & post a mockup here.

Comment 3

[Alfred Kayser]

Attachment: Orginal patched indiced with the changes described in comment #0

Comment 4

[Alfred Kayser]

Attachment: Centered pauze button

Pauze button was not centered, moved 1px to the left to make it centered.

Comment 5

[Justin Dolske [:Dolske]]

Comment on attachment 353426 [details]
Centered pauze button

It basically looks fine to me, but...

* Bug 464371 is spitting these into multiple PNGs (1 per button state).

* If we're going to clean these up, I'd also like to make them proper transparent images (ie, transparent background instead of dark gray).

Boriss, I assume you have original vector art for these buttons? Can you generate cleaned up versions with all these changes?

Comment 6

[Alfred Kayser]

Ok, understood. That will be much better.

Comment 7

[Alfred Kayser]

Attachment: Another example of fixed & transparent mediaplayer buttons.

Bug 464371 has split the image into four images, but didn't fix the issue of this bug. 
Btw, why split the image into separate images per button?
-moz-image-region was invented for the purpose of reducing the number of images in chrome (as they do impact performance of the browser overall).

Comment 8

[Justin Dolske [:Dolske]]

(In reply to comment #7)

> Btw, why split the image into separate images per button?
> -moz-image-region was invented for the purpose of reducing the number of images
> in chrome (as they do impact performance of the browser overall).

Because -moz-image-region doesn't work with background images.

Comment 9

[Alfred Kayser]

But as the buttons are now real xul buttons, a normal list-style-image would also work. And for making the background grey, background-color:grey would work ;-).

As said in other comments, the preference is to use transparent icons, and let the css do the styling... 

Note, I have done with my themes (such as Nautipolis and Walnut) and this works like a charm, with the added benefit that the browser provided controlBar as the same styling as the browser itself.

Comment 10

[Justin Dolske [:Dolske]]

Sure, but the purpose of bug 464371 was suppress the unexpected load events. For example:

<button onload="alert('load')" style="list-style-image: url(http://www.google.com/intl/en_ALL/images/logo.gif)"/>

When <video onload="..."> gets triggered because of these image loads events, that's a problem.

Comment 11

[Alfred Kayser]

So list-style-image do cause load events, but background-image not?

Comment 12

[Jennifer Morrow [:Boriss] (UX)]

Attachment: preview of video controls: slightly larger, glyphs different, opacity added

I agree with the jist of Comment 1, but would go a bit further.  I've posted new versions of the graphics, with some changes:

- Pause icon a better height/thickness ratio
- Colors of played/loaded/unloaded more distinct from each other
- Volume icon looks less like shuttlecock

- Colors and opacities of controls and background changed to look better on various backgrounds.  I've been playing around with this and think that a better solution than having the full opacity of the controls on top of the video is to have parts of it slightly transparent, so that some of the video can be seen below it.  This makes the controls more visually integrated - rather than something stamped on top of the video, something blended in.  If the background especially can be made slightly transparent, the difference is pretty striking (see preview).

Comment 13

[Jennifer Morrow [:Boriss] (UX)]

Attachment: .zip file of graphic elements in preview version

Comment 14

[Jennifer Morrow [:Boriss] (UX)]

Attachment: muted glyph - speaker w/no sound wave

pleaze to be provided

Comment 15

[Jennifer Morrow [:Boriss] (UX)]

Attachment: same icons in 24x24 boxen

Comment 16

[Jennifer Morrow [:Boriss] (UX)]

Attachment: the muted button moved to the left slightly, so it lines up with non-muted speaker

Comment 17

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Patch version of Boriss's icon update.

Comment 18

[Justin Dolske [:Dolske]]

Attachment: Screencap of Patch v.1

Comment 19

[Alex Faaborg [:faaborg] (Firefox UX)]

There are some gray lines on the inside edges of the pause button.  I'm not sure if this was intentional or not, and not a big enough deal to block ui-r+, but they might make the icon look ever so slightly fuzzy.

Comment 20

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 355898 [details] [diff] [review]
Patch v.1

a191=beltzner

Comment 21

[Jennifer Morrow [:Boriss] (UX)]

Attachment: same icons in 28x28

Comment 22

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/c2fae3249064

Comment 23

[Justin Dolske [:Dolske]]

Pushed to branch: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c007cf4d5fb4

Comment 24

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Play button moved one pixel to the right

Comment 25

[Tony Chung [:tchung]]

Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090313 Shiretoko/3.1b4pre Ubiquity/0.1.5
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090313 Minefield/3.2a1pre

Comment 26

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.