460315 - set journal_mode to TRUNCATE

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Shawn Wilsher :sdwilsh]

In order to upgrade SQLite, we need to set places journal_mode to TRUNCATE so we do not regress Ts on Linux.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 2

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/9753ccf72819

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

Looks like this has caused an increase in leak on:
WINNT 5.2 mozilla-central leak test build
Before:  195kb  After:  242kb
OS X 10.5.2 mozilla-central leak test build 
Before:  2.14mb after 2.19

Comment 5

[Shawn Wilsher :sdwilsh]

I think you are looking for bug 457158 and not this

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

Why would you point me to a month old bug when I saw the increase starting with the checkin of this bug ? 

The build with changeset 
http://hg.mozilla.org//mozilla-central/index.cgi/rev/a3fe1c305946 was 195kb,

the build just before the checkin of this bug, changeset:
http://hg.mozilla.org//mozilla-central/index.cgi/rev/9753ccf72819 
and the count went to 242kb and has stayed around that number for every build following.  

It may not be this exact bug, but it certainly didn't happen a month ago.  I am only posting what I see looking at the numbers in the waterfall tree - and trying to prevent another lengthy tree closure looking for why/when the leaks increased.

Comment 7

[Shawn Wilsher :sdwilsh]

I pointed you at that because I pushed this bug *along* with the SQLite upgrade, which is what caused that increase last time too...

Comment 8

[Shawn Wilsher :sdwilsh]

Comment on attachment 343423 [details]
v1.0

If we take bug 449443, we'll need this.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 343423 [details]
v1.0

Approved for 1.9.0.5, a=dveditz for release-drivers

Comment 10

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
new revision: 1.307; previous revision: 1.306

Comment 11

[Shawn Wilsher :sdwilsh]

This was backed out due to a possible dataloss regression.

Checking in toolkit/components/places/src/nsNavHistory.cpp;
new revision: 1.308; previous revision: 1.307