In order to upgrade SQLite, we need to set places journal_mode to TRUNCATE so we do not regress Ts on Linux.
Attachment #343423 - Attachment mime type: application/octet-stream → text/plain
Attachment #343423 - Flags: review?(dietrich) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Looks like this has caused an increase in leak on: WINNT 5.2 mozilla-central leak test build Before: 195kb After: 242kb OS X 10.5.2 mozilla-central leak test build Before: 2.14mb after 2.19
I think you are looking for bug 457158 and not this
Why would you point me to a month old bug when I saw the increase starting with the checkin of this bug ? The build with changeset http://hg.mozilla.org//mozilla-central/index.cgi/rev/a3fe1c305946 was 195kb, the build just before the checkin of this bug, changeset: http://hg.mozilla.org//mozilla-central/index.cgi/rev/9753ccf72819 and the count went to 242kb and has stayed around that number for every build following. It may not be this exact bug, but it certainly didn't happen a month ago. I am only posting what I see looking at the numbers in the waterfall tree - and trying to prevent another lengthy tree closure looking for why/when the leaks increased.
I pointed you at that because I pushed this bug *along* with the SQLite upgrade, which is what caused that increase last time too...
Comment on attachment 343423 [details] v1.0 If we take bug 449443, we'll need this.
Attachment #343423 - Flags: approval184.108.40.206?
Comment on attachment 343423 [details] v1.0 Approved for 220.127.116.11, a=dveditz for release-drivers
Attachment #343423 - Flags: approval18.104.22.168? → approval22.214.171.124+
Checking in toolkit/components/places/src/nsNavHistory.cpp; new revision: 1.307; previous revision: 1.306
This was backed out due to a possible dataloss regression. Checking in toolkit/components/places/src/nsNavHistory.cpp; new revision: 1.308; previous revision: 1.307
Attachment #343423 - Flags: approval126.96.36.199+ → approval188.8.131.52-
You need to log in before you can comment on or make changes to this bug.