460327 - remove opportunistic caching

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Dave Camp (:dcamp)]

The offline spec recently changed to remove the opportunistic caching feature.  Fallback still happens, but a successful load doesn't result in opportunistic caching.  This should be pretty easy to take out.

Comment 1

[Boris Zbarsky [:bzbarsky]]

It really sounds to me like this spec is too unstable to be implementing.... is it too late to just back out on shipping it?  :(

Comment 2

[Honza Bambas (:mayhemer)]

I would just #if 0 or #if OPPORTUNISTIC_CACHING_ENABLED'ed the code. It is not that big part to comment out this way or just remove usage (set) of the flag type NAMESPACE_OPPORTUNISTIC. This will disable the feature w/o huge changes to the code.

Comment 3

[Benjamin Smedberg]

Need to block on resolution of this one way or the other.

Comment 4

[Dave Camp (:dcamp)]

Attachment: quick-n-easy version

This is the smallest possible patch to remove this functionality;  It leaves support for opportunistic caching in the codebase, but won't actually use it for anything.

We could also do a complete opportunistic-ectomy, either here or in a followup.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 345379 [details] [diff] [review]
quick-n-easy version

Honza should look this over too...

And yeah, followup bug for ripping stuff out (maybe post-1.9.1 if needed) is ok.

Comment 6

[Dave Camp (:dcamp)]

http://hg.mozilla.org/mozilla-central/rev/838205b0621c