460440 - need to propagate aInherited parameter for when -moz-transform code calls CalcLength

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I saw the assertion caused by
NS_POSTCONDITION(!unused, "How did we inherit a value?");
during the style system mochitests, and this led me to the fact that we really do need to propagate that parameter; em units set aInherited to true since computations based on them can't be cached in the rule tree.  (We should probably rename some things in various places to make things clearer...)

This led me to write a test showing the bug this causes (reftest included in patch) and a patch to fix the problem.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 343538 [details] [diff] [review]
patch

There's some indentation weirdness going on here.  Tabs or something?

Also, why put aInherited before the other args in some cases, but all the way at the end in others?  Seems like it'd make more sense to toss it at the end of the arg list for ProcessTranslateX and so forth, so that the data/context/prescontext/inherited order is the same as in rulenode.

Comment 2

[Keith Schwarz [:kschwarz]]

Comment on attachment 343538 [details] [diff] [review]
patch

Looks great - thanks for fixing this!  Looks like I misinterpreted what the aInherited value meant during the initial implementation.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed:
http://hg.mozilla.org/mozilla-central/rev/0bb27db9264e
Also fixed the tabs from the transforms patch and in one other file:
http://hg.mozilla.org/mozilla-central/rev/b99df03358f2