460443 - Thunderbird can't hande correctly multiline subject header that contains CR+HTAB instead of CR+SPC

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Eero Volotinen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008070400 SUSE/3.0.1-0.1 Firefox/3.0.1
Build Identifier: 

Thunderbird can't hande correctly multiline subject header that contais CR+HTAB instead of CR+SPC

By definition multiline subject line contains:

2.  Subject Line Encoding

   The basic definition of the "Subject:" of an electronic mail message
   is contained in [RFC2822].  The normative requirements that apply to
   all headers are:

   o  The maximum length of the header field is 998 characters.

   o  Each line must be no longer than 78 characters.

   A multi-line subject field is indicated by the presence of a carriage
   return and white space, as follows:

        Subject: This
         is a test

Thunderbird works if multiline subject contais CR+SPC, but it bugs and shows square on windows or tab on Linux if smtp client creates standard multiline subject containing CR+HTAB

For example groupwise client uses CR+HTAB on multiline subject headers.

Eero

Reproducible: Always

Steps to Reproduce:
1.send multiline subject header contains email to and receive it by thunderbird
2. subjectline is not showed as correct
3.
Actual Results:  
thunderbird does not correctly show multiline subject header

Expected Results:  
thunderbird need to show multiline subject header correctly

CR+HTAB need to be handled like CR+SPC because this is defined in 
http://www.ietf.org/rfc/rfc4096.txt

Comment 1

[Eero Volotinen]

Steps to Reproduce:
1.send multiline subject header with CR+HTAB email to and receive it by thunderbird
2. subjectline is not showed as correct
3.

Comment 2

[Jan Horak [:jhorak]]

Attachment: Initial patch

I can fully reproduce with latest Thunderbird (3.0 beta4). Attaching a patch which should fix this issue.

Comment 3

[Jan Horak [:jhorak]]

Attachment: Message for reproducing

Reproduction with attached mail:
1. save attachement
2. open attached message via File/Open Saved Message...
3. see subject line "...devel	perl-..."

Comment 4

[Ludovic Hirlimann [:Usul]]

Comment on attachment 401819 [details] [diff] [review]
Initial patch

Changing review requestee. Thanks for the patch.

Comment 5

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #0)
> Thunderbird can't hande correctly multiline subject header that contais CR+HTAB
> instead of CR+SPC

(Q1) What Tb's behaviour or phenomenon is "Thunderbird can't handle correctly"?

(In reply to comment #1)
> Steps to Reproduce:
> 1.send multiline subject header with CR+HTAB email to and receive it by
> thunderbird
> 2. subjectline is not showed as correct

(Q2) Which case? Both? 
  (a) Subject: text1[CRLF][HTAB]text2[CRLF]
  (b) Subject: RFC2047-encoded-word-1[CRLF][HTAB]RFC2047-encoded-word-2[CRLF]
(Q3) What phenomenon do you mean by "not showed as correct"?
  (c) [HTAB] in (a) is displayed as U+FFFD at thread pane. (known issue)  
      Display at message header pane is not affected. (displayed as space)
  (d) If (c), RFC2047 decoding fails, because space between consecutive
      RFC-2047 encoded words should be 0x20 instead of [HTAB]. 
      (AFAIR, this is also already reported problem, but I'm not sure.)

(In reply to comment #2)
> Initial patch

(Q4) It looks quirks for (d). Is it right?

Comment 6

[WADA:World Anti-bad-Duping Agency]

attached mail is (a). proposed patch works for both (a) and (b)?

Comment 7

[Jan Horak [:jhorak]]

Attachment: Subject with tabs encoded by RFC2047

Attaching type (b) of message. This is even working fine without patch.

Comment 8

[Jan Horak [:jhorak]]

Any chance to commit?

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/52c3382d86d3