460466 - Clicking on an autocompleted <INPUT> disables autocomplete for that window

Status: RESOLVED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[[e-mail]]

Steps to reproduce problem
1. Cause the inline autocomplete popup to appear
2. Click on the <INPUT>
3. Notice that autocomplete does not function for that window

What happens is this:
1. The mouse down event dismisses the popup (via nsWindow::DealWithPopups and nsXULPopupManager::Rollup)
2. The form fill controller notices the click on the <INPUT> and tries to open the popup (which is normal behaviour when the popup is closed)
3. The XUL popup manager notices that it just rolled up the popup and refuses to open the popup
Unfortunately autocomplete.xml now thinks the popup is open and won't let you open the popup again.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[asmpgmr]

I applied the changes listed in the bug to content\global\autocomplete.xml in toolkit.jar on my system and can verify it works. 

Note bug 460339 opened by me is the same bug and can be considered a duplicate.

Comment 4

[asmpgmr]

It would be nice if this fix could be in the next beta especially since there currently isn't a form manager in SeaMonkey 2 yet.

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 343562 [details] [diff] [review]
Proposed patch

Patch inspection looks good and sane;

I never tested and am not extremely familiar here, but Neil; if you trust that as a sane review, feel free to use my r+

Comment 6

[[e-mail]]

Pushed changeset 26403004f658 to mozilla-central.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f11503f5c3e9
Clicking on autocompleted <input> disables autocomplete for that window r=Callek NPOTB