Closed Bug 460556 Opened 14 years ago Closed 14 years ago

Needs automated test for bug 460500

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1.0 (obsolete) — Splinter Review
We need mod key pressing tests. However, on Windows, I need more work and it conflicts my another patch. So, I will work for Windows later. In this bug, we should fix only on Mac.
Attachment #343686 - Flags: superreview?(roc)
Attachment #343686 - Flags: review?(roc)
Attachment #343686 - Flags: superreview?(roc)
Attachment #343686 - Flags: review?(roc)
Attachment #343686 - Flags: review-
Comment on attachment 343686 [details] [diff] [review]
Patch v1.0

Ah, this patch have some mistakes, sorry for the spam.
Comment on attachment 343686 [details] [diff] [review]
Patch v1.0

Simply mark it as obsolete in such a case.
Attachment #343686 - Attachment is obsolete: true
Attachment #343686 - Flags: review-
Attached patch Patch v2.0Splinter Review
Attachment #343692 - Flags: superreview?(roc)
Attachment #343692 - Flags: review?(roc)
(In reply to comment #3)
> Created an attachment (id=343692) [details]
> Patch v2.0

Masayuki, the patch contains several other things beneath the tests. Is this expected?
Yes. The testing mechanism is not complete, we need to improve the code, but it must not affect the actual behavior, therefore, I separated the bug/patch from bug 460500.
Attachment #343692 - Flags: superreview?(roc)
Attachment #343692 - Flags: superreview+
Attachment #343692 - Flags: review?(roc)
Attachment #343692 - Flags: review+
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Masayuki, it would be great to also post the hg changeset link for further check-ins. Thanks.

http://hg.mozilla.org/mozilla-central/rev/fa62ea8a60ca
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.1b2
You need to log in before you can comment on or make changes to this bug.