460587 - Ctrl-Tab background is grey on Vista (No Aero Glass effect)

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[u88484]

The background for Ctrl-Tab preview pane is grey and no longer has the aero glass effect.

Not sure when this happened but I'm on the 20081017033517 build.
http://hg.mozilla.org/mozilla-central/rev/8d0e5b53857f

Comment 1

[u88484]

Attachment: Screenshot

Comment 2

[Tyler Downer [He/Him]]

I am seeing this as well on the trunk.

Comment 3

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081018 Minefield/3.1b2pre ID:20081018033524

WFM, maybe Vista specific

Comment 4

[Tyler Downer [He/Him]]

Can you give a screenshot of the XP tab preview?

Comment 5

[Peter van der Woude [:Peter6]]

Attachment: screenshot with XP

Comment 6

[Tyler Downer [He/Him]]

Interesting.

Comment 7

[Tyler Downer [He/Him]]

We will need to set up a regression range for this, can someone maybe start on that?

Comment 8

[u88484]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c6fcfc205aca&tochange=ea37481b6803

Looks like a good possibility bug 450944 caused this. 

CCing Markus Stange

Comment 9

[Markus Stange [:mstange]]

It's unlikely that this is caused by bug 450944. It mostly touches Mac-only code, and where it touches cross-platform code (e.g. http://hg.mozilla.org/mozilla-central/diff/fbb71be15c4d/layout/xul/base/src/nsMenuPopupFrame.cpp ) I didn't change any behaviour as far as I can see.

Could somebody confirm this by doing a local backout of changeset fbb71be15c4d? I can't test on Vista.

CCing Rob Arnold, the Vista Glass guy.

Comment 10

[Markus Stange [:mstange]]

(In reply to comment #9)
> http://hg.mozilla.org/mozilla-central/diff/fbb71be15c4d/layout/xul/base/src/nsMenuPopupFrame.cpp

Oops, haha. I'm blind this morning. Taking.

Comment 11

[Markus Stange [:mstange]]

fixed: http://hg.mozilla.org/mozilla-central/rev/b9a8515b4bed

Sorry that I didn't pay attention when I merged.