460593 - Leaving history window open with a filter causes hangs if new sites are added to history while window is opening (e.g. browsing is done)

Status: RESOLVED DUPLICATE of bug 494082

(Firefox :: Bookmarks & History, defect)

Description

[Thomas K. (:tom)]

Build identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081017 Firefox/3.0.3pre

the part at the end is custom because otherwise stupid websites get confused

Repro (for me, anyway)
1) Open History, Show All History
2) type something in the filter, preferably a site you've been to before (for me, "encyclopediadramatica")
3) click the item you were looking for, opening up the page in the browser
4) click something on that page linking to another page on the same domain
5) experience hang that requires a force quit (sometimes, other times you can keep waiting, no matter what you beachball pretty badly)

Theory:
When you browse to another page, the places.sqlite is updated, and history has to reprocess the whole file for some reason, and even though it's in the background and not even being used it keeps getting updated.

Suggested Solution:
History stops searching or updating when it's not foreground.

This happened in the 3.0 branch too, even before final.

Comment 1

[Yuliy Pisetsky]

I can confirm something similar to this. It is not a full hang, but just nonresponsiveness for 3 seconds or so. Note that this does not go away until Firefox is restarted. Closing the history window does NOT return to normal behavior. Easiest way I tested was just going to google.com and clicking back and forth rapidly between "Web" and "Images" repeatedly. Also note that this does not happen every page load, but approximately every 3 or 4 page loads.

Comment 2

[Marco Bonardo [:mak]]

Should be a minor issue now that Library splits history, still not good though.

Comment 3

[Marco Bonardo [:mak]]

"Closing the history window does NOT return to normal behavior."

This is probably the result that is still in memory and updating, see bug 324430.

Comment 4

[Marco Bonardo [:mak]]

i'm going to dupe to bug 494082.

We did a bunch of fixes to both search (bug 500391) and views (bug 498130), so this should be better.