460595 - Cannot drag text selection in input control

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect, P1)

Description

[Elmar Ludwig]

Since the checkin of the patch for bug 459323, dragging a text selection from an input control (text area or text field) does no longer work. There is no drag cursor and dropping has no effect.

Steps to reproduce:

1. Select some text in some input control.
2. Try to drag the text with the mouse.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081018 Minefield/3.1b2pre

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Asaf, could you explain this a bit.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Ah, nevermind. Bug 455215 explains this.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 343752 [details] [diff] [review]
patch

I assume you have tested dragging from and to <input> and <textarea> etc.

Neil, can you think of any easy way to add tests for this all? We really really need such tests.

The patch looks ok, but I'd either like to have tests or some explanation why automatic testing isn't possible.

Comment 5

[Neil Deakin]

You can't automate testing of drag and drop code that relies on the dragservice or the native apis to be called (and succeed). You can test some aspects of the new drag and drop api with the methods in bug 456093.

The editor code still uses the old api though. Changing that is ultimately the right fix for a lot of the editor code, but that's a larger task.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Can we at least get all these d&d tests into litmus?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 343752 [details] [diff] [review]
patch

Ok, we need this. r=me if you add some tests after Enn's patch and make sure that this gets to litmus.

Comment 8

[Asaf Romano (gone)]

http://hg.mozilla.org/mozilla-central/rev/757e0b46013a

Comment 9

[IU]

Bugs still remain.  Just filed: Bug 460903

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

In the meantime, this needs to land on 191, pronto.

Comment 11

[Asaf Romano (gone)]

Beltzner, did you see the landing date?

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Ah, I see, this landed before we branched. Thanks, Mano. Marking fixed1.9.1.