460608 - Download of temporary files for helper applications are stored in downloads.sqlite while private browsing is active

Status: RESOLVED WORKSFORME

(Firefox :: Private Browsing, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While testing the latest try server build on bug 248970 I noticed that temporary files for helper applications are stored within downloads.sqlite. Shouldn't they resist within the in-memory database? Curiously I can only see this behavior on OS X and I'm not able to reproduce it on Windows.

Steps:
1. Start Firefox and activate Private Browsing (save current session)
2. Search for "pdf" on Google
3. Open a pdf file with an external application
4. Close external application
5. Restart Firefox
6. Open Download Manager

As you can see in step 6 the opened pdf file is still listed within the Download Manager.

Comment 1

[(no longer active)]

Unfortunately, I don't have a Mac, so I can't test this.  I need to know whether the same thing happens with the STR below or not?

1. Start Firefox and activate Private Browsing (save current session)
2. Search for "pdf" on Google
3. Open a pdf file with an external application
4. Close external application
5. Exit the Private Browsing mode.
6. Open Download Manager

If this can't be reproduced this way, then I might have a clue on what's going wrong... :-)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ehsan, I did some short tests (lack of time today) and I've noticed that the problem doesn't occur anymore with the latest try server build. Have you fixed something in the download manager code?

There were a lot of checkins lately on trunk. When it will be possible to have a test-run with an official nightly build? I should have a closer look again.

Comment 3

[(no longer active)]

(In reply to comment #2)
> Ehsan, I did some short tests (lack of time today) and I've noticed that the
> problem doesn't occur anymore with the latest try server build. Have you fixed
> something in the download manager code?

Nope, not in quite some time.  Can you figure out which try server build you were using when you saw this problem?

> There were a lot of checkins lately on trunk. When it will be possible to have
> a test-run with an official nightly build? I should have a closer look again.

I'm landing the private browsing parts in chunks, the final landing should happen by the end of this week (that's the schedule currently set, at least) if I get all the required reviews by that time.

Comment 4

[(no longer active)]

Henrik, can you reproduce the original problem in comment 0?  I just tried with the latest patch and couldn't reproduce this.  If it can't be reproduced, I guess we should resolve it as WORKSFORME.

Comment 5

[(no longer active)]

OK, silly me.  Comment 0 explicitly states that this only happens in OS X, but I tested this on Windows.  Still, can you reproduce this?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'm not able to reproduce it anymore. Leaving the Private Browsing mode successfully replaces the list with the one from the original session. Marking at WFM.

Comment 7

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.