460799 - Move JS code out of bug/comments.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Frédéric Buclin]

The JS code in comments.html.tmpl doesn't depend on the data passed to it, so we can move it out of the template. It should go somewhere in js/.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Moved js code to js/comments.js.

Comment 2

[Frédéric Buclin]

Comment on attachment 444074 [details] [diff] [review]
Moved js code to js/comments.js.

>=== added file 'js/comments.js'

>+ * Contributor(s): Gervase Markham <[e-mail]>
>+  #                Max Kanat-Alexander <[e-mail]>
>+  #                Shane H. W. Travis <[e-mail]>
>+  #                Edmund Wong <[e-mail]>
>+ */

Each line of the contributor list must start with *, not with #, in JS files.


>+function toggle_all_comments(action) {
>+    var num_comments = [% comments.size FILTER html %];

[% ... %] is TT code, not JS code. You have to pass this argument to toggle_all_comments() when calling it from the template.


Otherwise looks good.

Comment 3

[Frédéric Buclin]

Comment on attachment 444074 [details] [diff] [review]
Moved js code to js/comments.js.

>=== added file 'js/comments.js'

>+ * Contributor(s): Gervase Markham <[e-mail]>
>+  #                Max Kanat-Alexander <[e-mail]>
>+  #                Shane H. W. Travis <[e-mail]>
>+  #                Edmund Wong <[e-mail]>

Oh, and while you are on it, please remove Shane and Gervase names from the list of contributors for the JS script, as they didn't alter the JS part of the template at all, and add mine instead, as I forgot to do it when committing bug 262275. Thanks!

Comment 4

[Edmund Wong (:ewong)]

Attachment: Moved js code to js/comments.js. (v2)

Comment 5

[Frédéric Buclin]

Comment on attachment 445707 [details] [diff] [review]
Moved js code to js/comments.js. (v2)

Works fine, thanks! r=LpSolit

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
added js/comments.js
modified template/en/default/bug/comments.html.tmpl
Committed revision 7176.