Last Comment Bug 460932 - text-indent and text-align should really be object attributes
: text-indent and text-align should really be object attributes
Status: RESOLVED FIXED
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: alexander :surkov
:
:
Mentors:
Depends on:
Blocks: textattra11y texta11y
  Show dependency treegraph
 
Reported: 2008-10-21 00:39 PDT by Aaron Leventhal
Modified: 2008-10-28 04:56 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (30.53 KB, patch)
2008-10-24 00:08 PDT, alexander :surkov
aaronlev: review+
mzehe: review+
Details | Diff | Splinter Review

Description Aaron Leventhal 2008-10-21 00:39:04 PDT
It was a mistake to implement these 2 as text attributes. They should be object attributes:

See http://www.linuxfoundation.org/en/Accessibility/IAccessible2/ObjectAttributes
Comment 1 alexander :surkov 2008-10-24 00:08:03 PDT
Created attachment 344597 [details] [diff] [review]
patch
Comment 2 Aaron Leventhal 2008-10-24 12:56:53 PDT
Roc mentioned that getComputedStyle can cause perf issues. Shouldn't we be asking the frame for info? We do have some major perf issues recently filed about text attributes, which used getComputedStyle.
Comment 3 alexander :surkov 2008-10-24 22:51:50 PDT
(In reply to comment #2)
> Roc mentioned that getComputedStyle can cause perf issues. Shouldn't we be
> asking the frame for info? We do have some major perf issues recently filed
> about text attributes, which used getComputedStyle.

Yes but Roc said we shouldn't care until we get info it's really perf issue. These text attributes were calculated by getComputedStyle, so I don't change anything when I start to expose them as object attributes. Also I think real perf issue of text attributes is we navigate DOM tree every time for every text attribute.
Comment 4 Marco Zehe (:MarcoZ) 2008-10-28 02:19:52 PDT
Comment on attachment 344597 [details] [diff] [review]
patch

r=me for the test part.
Comment 5 alexander :surkov 2008-10-28 04:56:04 PDT
http://hg.mozilla.org/mozilla-central/rev/475af432efb1

Note You need to log in before you can comment on or make changes to this bug.