The default bug view has changed. See this FAQ.

text-indent and text-align should really be object attributes

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Aaron Leventhal, Assigned: surkov)

Tracking

(Blocks: 2 bugs, {access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

30.53 KB, patch
Aaron Leventhal
: review+
MarcoZ
: review+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
It was a mistake to implement these 2 as text attributes. They should be object attributes:

See http://www.linuxfoundation.org/en/Accessibility/IAccessible2/ObjectAttributes
(Assignee)

Updated

9 years ago
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
(Assignee)

Comment 1

9 years ago
Created attachment 344597 [details] [diff] [review]
patch
Attachment #344597 - Flags: review?(aaronleventhal)
(Assignee)

Updated

9 years ago
Attachment #344597 - Flags: review?(marco.zehe)
(Reporter)

Comment 2

9 years ago
Roc mentioned that getComputedStyle can cause perf issues. Shouldn't we be asking the frame for info? We do have some major perf issues recently filed about text attributes, which used getComputedStyle.
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> Roc mentioned that getComputedStyle can cause perf issues. Shouldn't we be
> asking the frame for info? We do have some major perf issues recently filed
> about text attributes, which used getComputedStyle.

Yes but Roc said we shouldn't care until we get info it's really perf issue. These text attributes were calculated by getComputedStyle, so I don't change anything when I start to expose them as object attributes. Also I think real perf issue of text attributes is we navigate DOM tree every time for every text attribute.

Updated

9 years ago
Attachment #344597 - Flags: review?(marco.zehe) → review+

Comment 4

9 years ago
Comment on attachment 344597 [details] [diff] [review]
patch

r=me for the test part.
(Reporter)

Updated

9 years ago
Attachment #344597 - Flags: review?(aaronleventhal) → review+
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/rev/475af432efb1
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.