460967 - Sorting of tasks to their title in the task-tree is not working

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Berend Cornelius]

The sorting of tasks in the task is not working when the sorting field is a text field.

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

The locale collator was not created properly because the interface was not passed

Comment 2

[Berend Cornelius]

Attachment: patch v. #1.1

This is the right patch.

Comment 3

[Daniel Boelzle [:dbo]]

Comment on attachment 344100 [details] [diff] [review]
patch v. #1.1

Ah! Now I understand why the bug didn't show up: calUtils.js' functions are loaded into the |cal| object (at the end of calUtils.jsm). That way the previous buggy definition won't have effect.

>     createLocaleCollator: function cal_createLocaleCollator() {
>-      var localeService = generateServiceAccessor("@mozilla.org/intl/nslocaleservice;1");
>-      return generateServiceAccessor("@mozilla.org/intl/collation-factory;1")
>+      var localeService = generateServiceAccessor("@mozilla.org/intl/nslocaleservice;1", Components.interfaces.nsILocaleService);
>+      return generateServiceAccessor("@mozilla.org/intl/collation-factory;1", Components.interfaces.nsICollationFactory)
>             .CreateCollation(localeService.getApplicationLocale());
>      },
> 

I don't see why this will work, because generateServiceAccessor returns a *function*, not an object, and has been designed to be used *only* for plain service accessors like getIOService.
The definition of createLocalCollator from calUtils.js (old file) is *OK*, probably just needs some indentation. Just move it over to calUtils.jsm.

Comment 4

[Stefan Sitter [:ssitter]]

Can you explain what is going wrong and provide steps to reproduce the issue? 

Seems to work for me using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090324 Calendar/1.0pre. During my test I used tasks with titles like "AAA", "áaa", "aba", "àca", "äöü", "foo", "zzz" and the sort order looks correct.

Comment 5

[Martin Schröder [:mschroeder]]

Attachment: Patch v2

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 385433 [details] [diff] [review]
Patch v2

r=philipp

Comment 7

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c10119db13ca>

-> FIXED

Comment 8

[Damian Szczepanik]

verifying with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100305 Calendar/1.0b2pre

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".