Closed
Bug 460979
Opened 17 years ago
Closed 17 years ago
No display crashes in nsIdleServiceGTK.cpp
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: jcranmer, Assigned: jcranmer)
References
Details
(Keywords: crash, regression)
Attachments
(1 file)
|
660 bytes,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
If there is no display, nsIdleServiceGTK crashes in GetIdleTime because it calls PR_LOG on a null sIdleLog.
|
Assignee | |
Comment 1•17 years ago
|
||
Regression from bug 397607, based on hg annotate and analysis of patch.
Blocks: 397607
Keywords: crash,
regression
|
|
Assignee | |
Comment 2•17 years ago
|
||
This patch moves the initialization of the module back into the constructor instead of the Initialize function (which is called too late).
Assignee: nobody → Pidgeot18
Status: NEW → ASSIGNED
Attachment #344111 -
Flags: superreview?(roc)
Attachment #344111 -
Flags: review?(roc)
|
||
Comment 3•17 years ago
|
||
Comment on attachment 344111 [details] [diff] [review]
Stop the crashing
This looks sensible.
Attachment #344111 -
Flags: superreview?(roc)
Attachment #344111 -
Flags: superreview+
Attachment #344111 -
Flags: review?(roc)
Attachment #344111 -
Flags: review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Checked in:
changeset: 20744:20de2f0b83c8
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in
before you can comment on or make changes to this bug.
Description
•