Closed
Bug 460999
Opened 16 years ago
Closed 16 years ago
Generate and upload class inheritance diagrams for MDC
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
Details
Attachments
(1 file)
9.97 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
This is a small update for the automatic string documentation: it takes the two base classes nsAString and nsACString and generates a dot-format graph of all subclasses. It then converts this to PNG and a image map and uploads all that to MDC. Asking jorendorff for review mostly because the hairiest parts of the patch are the additions to deki.py
Attachment #344131 -
Flags: review?(jorendorff)
Updated•16 years ago
|
Attachment #344131 -
Flags: review?(jorendorff) → review+
Comment 1•16 years ago
|
||
Comment on attachment 344131 [details] [diff] [review] Graph string class hierarchy, rev. 1 >+ def create_file(self, page, name, data, mimetype, description=None): Please name this something like attach_file, save_file, or upload_file. (You don't just use it to create files.) Given "MDC-attach.py", maybe attach_file is best. >+ data - fd or str - a string or file object with the file data Does this really work with a filelike object? I couldn't find where that's implemented. Do you want to revise this patch now that the graphviz plugin is supposedly up and running on MDC? If not, r=me with the first 2 comments addressed.
Assignee | ||
Comment 2•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6a2e65f15f48 No, it doesn't work with file-like objects, I was confused about what urllib2 accepted. I would like to do this with the graphviz plugin, but that doesn't work yet... probably some configuration issue, but I'm not sure.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•