461013 - get rid of |aTab.localName != "tab"| checks in removeAllTabsBut, removeTab and reloadTab

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

from bug 456002 comment 15:

> (From update of attachment 339788 [details] [diff] [review])
> (In reply to comment #14)
> > The current behavior doesn't seem to make sense to me and bugs me every time I
> > look at it (and others, e.g. bz in bug 113934), but it never seemed important
> > enough to file a bug. Do you want me to file a separate bug? Or can you explain
> > why the code is doing what it's doing?
> 
> I actually misinterpreted it as a null check; I agree that it doesn't make much
> sense as it is. Bug 107848 comment 25 suggests that event listeners on non-tab
> elements used to pass |this| as the parameter, or something. I think we can
> probably get rid of it, but a new bug would be good.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/0c338f85aacd

Comment 3

[Dão Gottwald [:dao]]

Attachment: followup

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/4020e95b0e4e