461042 - Setting a keyword's search engine now fails without an error message if the keyword already exists

Status: RESOLVED DUPLICATE of bug 728508

(Firefox :: Search, defect)

Description

[Lee Houghton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081019 Minefield/3.1b2pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081019 Minefield/3.1b2pre (.NET CLR 3.5.30729)

I'm not sure what changed, but I believe this used to give an error message (I can't find what it was, though; I'd expect it to be in http://mxr.mozilla.org/firefox/source/browser/locales/en-US/chrome/browser/search.properties but it's not).

Reproducible: Always

Steps to Reproduce:
1. Go to thesaurus.reference.com and choose "Add a keyword for this search", using "th" as the bookmark's keyword.
2. Add the opensearch version from http://mycroft.mozdev.org/dlstats.html (currently 8th on the list).
3. Attempt to set the keyword for this to "th" via "Manage Search Engines...".
Actual Results:  
Setting the keyword does not do anything. No explanation or error message is shown.

Expected Results:  
A message is shown saying that the chosen keyword is already in use. This used to happen, IIRC.

Ideally I'd prefer it to also allow deleting the existing bookmark, which makes sense when "upgrading" from keyworded bookmarks to opensearch, in addition to doing nothing.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Regression from Firefox 3.0.x. Confirmed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre) Gecko/20090831 Shiretoko/3.5.4pre ID:20090831030742

We would need the regression range. As what a quick look shows it regressed sometimes before 3.1 beta 1.

Comment 2

[Michael Kohler [:mkohler]]

broken
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a2pre) Gecko/20080814020600 Minefield/3.1a2pre

works
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a2pre) Gecko/20080813020710 Minefield/3.1a2pre

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Michael, can you please provide the changesets for both builds. We still haven't found the causing bug so adding back the regression-window wanted keyword.

Comment 4

[Michael Kohler [:mkohler]]

(In reply to comment #3)
> Michael, can you please provide the changesets for both builds. We still
> haven't found the causing bug so adding back the regression-window wanted
> keyword.

about:buildconfig doesn't have this information in these builds.

Comment 5

[Tracy Walker [:tracy]]

from http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-08-13+01%3A00%3A00&enddate=2008-08-14+08%3A00%3A00

That's close enough for this bug.  From that list, I might guess bug 429091

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yeah. It's the only bug for the search component which touches the keyword code. Thanks.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

I am seeing an error message about the duplicate search keyword using Firefox Nightly 22 on Win7. Please reopen if you still see this bug.