461058 - Resizing window before showing Tabsposé leads to multiple aspect ratios

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Multiple aspect ratios

STR:

1) Open several tabs
2) In the current tab, resize the window (e.g., Apple.com to fit the width)
3) Invoke Tabsposé
--> Observe tab aspect ratios
4) Close Tabsposé and switch tabs (say, to google.com)
5) Resize the new tab
6) Invoke Tabsposé
--> Observe tab aspect ratios

ER: Tab previews all have the same aspect ratio (matching the current window)

AR: Tab previews have multiple aspect ratios, with each preview having the aspect ratio of the window the last time that tab was visited.

Comment 1

[philippe (part-time)]

You are resizing the window using the widget on the window title bar, correct ? When I use the little grip at the bottom of the window, I don't see any problems.

Comment 2

[Stuart Morgan]

Since we don't cache the thumbnails, I'm perplexed as to how this could happen.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> You are resizing the window using the widget on the window title bar, correct ?
> When I use the little grip at the bottom of the window, I don't see any
> problems.

No, the resize widget at the bottom-right.

(In reply to comment #2)
> Since we don't cache the thumbnails, I'm perplexed as to how this could happen.

Since we're asking Gecko to thumbnail, is Gecko not being notified of the new window size until a tab is shown, so that it thinks that the window size is still what it was when each tab was originally created (or last viewed)?

Comment 4

[Stuart Morgan]

Quite possibly; I think we do in fact have code to prevent doing resizing in background tabs for performance reasons. Excellent thought.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://es.appleweblog.com/2008/12/24/camino-2-beta-1/ has a real-world example of this bug.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> Quite possibly; I think we do in fact have code to prevent doing resizing in
> background tabs for performance reasons. Excellent thought.

This comment at the beginning of BrowserWrapper's |setFrame:resizingBrowserViewIfHidden:|, for instance? http://mxr.mozilla.org/camino/source/camino/src/browser/BrowserWrapper.mm#380

I'm not sure how that would get down to Gecko, but it does sound like the code in question.

OTOH, I don't know if we want to slow Tabsposé down any further by forcing a resize of all tabs in a window before thumbnailing :(