461066 - Add support for XHR's loadend event

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Loadend event has been added to http://dev.w3.org/cvsweb/~checkout~/2006/webapi/progress/Progress.html?rev=1.25

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

XHR2 should be updated before this, and also HTML 5.
I think XHR2/upload should have property onloadend, not sure about <video>/<audio>

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

<audio> / <video> seem to have a bit different kind of use for progress events
and they have more events. So not even sure if loadend is useful there.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I talked to hixie about this. His feeling was that it seemed to make sense for audio/video too given that we have load/abort/error there too.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 519217 [details] [diff] [review]
patch

Yay!

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Actually, could you add this event to the cross-site XHR tests too by adding loadend to the list here:

http://mxr.mozilla.org/mozilla-central/source/content/base/test/file_CrossSiteXHR_inner.html?force=1#28

and change the code here to use the loadend event instead:
http://mxr.mozilla.org/mozilla-central/source/content/base/test/file_CrossSiteXHR_inner.html?force=1#51

It's unfortunately a bit of a pain since you also need to update

file_CrossSiteXHR_inner.jar
file_CrossSiteXHR_inner_data.sjs

:(

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Could you explain that whole CORS testing setup?
Why the need for .jar?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

I'll push the patch, since it does tests all the parts already, but
we certainly should have tests for xsite+loadend too.
Filed a followup for that.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/3a362ae1d54c

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Fix CORS-tests to also check for loadend

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in CORS tests

http://hg.mozilla.org/mozilla-central/rev/2ecbb2d07d85

Comment 12

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/XPCOM_Interface_Reference/NsIXMLHttpRequestEventTarget
https://developer.mozilla.org/En/XMLHttpRequest/Using_XMLHttpRequest#Detecting_any_load_end_condition

And listed on Firefox 5 for developers.