Last Comment Bug 461066 - Add support for XHR's loadend event
: Add support for XHR's loadend event
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug] (high review load, please consider other reviewers)
:
Mentors:
Depends on: 644568
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-21 16:59 PDT by Olli Pettay [:smaug] (high review load, please consider other reviewers)
Modified: 2011-04-14 06:24 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (33.94 KB, patch)
2011-03-14 13:08 PDT, Olli Pettay [:smaug] (high review load, please consider other reviewers)
jonas: review+
Details | Diff | Review
Fix CORS-tests to also check for loadend (14.29 KB, patch)
2011-03-25 18:30 PDT, Jonas Sicking (:sicking) PTO Until July 5th
bugs: review+
Details | Diff | Review

Description Olli Pettay [:smaug] (high review load, please consider other reviewers) 2008-10-21 16:59:09 PDT
Loadend event has been added to http://dev.w3.org/cvsweb/~checkout~/2006/webapi/progress/Progress.html?rev=1.25
Comment 1 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2008-10-23 04:06:13 PDT
XHR2 should be updated before this, and also HTML 5.
I think XHR2/upload should have property onloadend, not sure about <video>/<audio>
Comment 2 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2008-10-23 04:27:24 PDT
<audio> / <video> seem to have a bit different kind of use for progress events
and they have more events. So not even sure if loadend is useful there.
Comment 3 Jonas Sicking (:sicking) PTO Until July 5th 2008-10-25 00:07:33 PDT
I talked to hixie about this. His feeling was that it seemed to make sense for audio/video too given that we have load/abort/error there too.
Comment 4 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-03-14 13:08:49 PDT
Created attachment 519217 [details] [diff] [review]
patch
Comment 5 Jonas Sicking (:sicking) PTO Until July 5th 2011-03-21 18:25:24 PDT
Comment on attachment 519217 [details] [diff] [review]
patch

Yay!
Comment 6 Jonas Sicking (:sicking) PTO Until July 5th 2011-03-21 18:32:22 PDT
Actually, could you add this event to the cross-site XHR tests too by adding loadend to the list here:

http://mxr.mozilla.org/mozilla-central/source/content/base/test/file_CrossSiteXHR_inner.html?force=1#28

and change the code here to use the loadend event instead:
http://mxr.mozilla.org/mozilla-central/source/content/base/test/file_CrossSiteXHR_inner.html?force=1#51

It's unfortunately a bit of a pain since you also need to update

file_CrossSiteXHR_inner.jar
file_CrossSiteXHR_inner_data.sjs

:(
Comment 7 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-03-24 06:12:06 PDT
Could you explain that whole CORS testing setup?
Why the need for .jar?
Comment 8 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-03-24 06:45:46 PDT
I'll push the patch, since it does tests all the parts already, but
we certainly should have tests for xsite+loadend too.
Filed a followup for that.
Comment 9 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-03-24 10:22:52 PDT
http://hg.mozilla.org/mozilla-central/rev/3a362ae1d54c
Comment 10 Jonas Sicking (:sicking) PTO Until July 5th 2011-03-25 18:30:04 PDT
Created attachment 522046 [details] [diff] [review]
Fix CORS-tests to also check for loadend
Comment 11 Jonas Sicking (:sicking) PTO Until July 5th 2011-03-28 14:26:10 PDT
Checked in CORS tests

http://hg.mozilla.org/mozilla-central/rev/2ecbb2d07d85

Note You need to log in before you can comment on or make changes to this bug.