461106 - Focus lost after closing Tabsposé

Status: VERIFIED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[philippe (part-time)]

STR
1. have multiple tabs open (longer pages, links)
2. open Tabsposé
3. close Tabsposé without switching tabs

ER: able to navigate the page with the keyboard (pgDown, spacebar, tab to links, continue typing in this textarea).
AR: nothing happens. Sniff.

10.5.5 with FKA on.

Comment 1

[Chris Lawson (gone)]

Happens on PPC, too.

Comment 2

[Stuart Morgan]

Attachment: fix

This turned out to be completely separate from implementing a working tab chain.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 406626 [details] [diff] [review]
fix

sr=pink

IIRC we have this snippet of code elsewhere as well. Would it be useful to just wrap it into a helper method called something like "-ensureSomethingHasFocus"?

Comment 4

[Stuart Morgan]

Landed on CVS trunk and CAMINO_2_0_BRANCH.

The other place we do this is part of more complex conditional logic, so there's no good way to extract this bit.

Comment 5

[philippe (part-time)]

This works fine now, thanks !

However, there is a flip side: if the active tab in the STR is the BM manager (or History), then the focus is completely lost (it sorta worked before the patch: with a bookmark focussed, going in and out of tabsposé would not return the focus to that bookmark, but one tab would put the focus on the left column). Now the focus is nowhere and tabbing just beeps. Putting the focus on e.g. the find bar or the BM search field and tabbing from there works though.

(I don't think I ever tested that scenario before…)

Comment 6

[Stuart Morgan]

Sigh; someday I'll fix a bug without regressing something. Please file a new bug for that, since the most common case has been fixed and it'll be easier to track in a new bug.

Comment 7

[philippe (part-time)]

Filed bug 522919 for the BM manager issue.

Meanwhile, marking this one as verified.