461124 - Mode/Tab doesn't change when using Alt+[1234]

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

STR:

* Go into mail mode
* Press Alt+1 (or 2,3,4)


Result:

* Title changes to include the view's date range
* No calendar tab is opened


Expected (variant 1):

* Calendar Tab is opened
* Corresponding view is shown

Expected (variant 2):
* No title change
* No calendar tab is opened

Comment 1

[Przemyslaw Bialik]

What is the really expected variant ?
I think I would propose #2 and leave only Ctrl+3 to switch to the calendar.

BTW calendar-common-sets.xul:
>  #ifdef XP_MACOSX
>    // The following Mac specific code-lines are necessary, because you can't
mac specific code shouldn't apply also to windows ;)
also this file is not being preprocessed.

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: [checked in] enable preprocessing of calendar-common-sets.xul

Only tested in Sunbird, don't know if this patch fixes the Lightning tab issue too.

Comment 3

[Daniel Boelzle [:dbo]]

Comment on attachment 348837 [details] [diff] [review]
[checked in] enable preprocessing of calendar-common-sets.xul

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/d882e901e3f6>

Comment 4

[Przemyslaw Bialik]

Attachment: Fix v1

Switching views (alt+1234) works only when in calendar tab

At first I had planned to check if calendar tab is selected but it doesn't have the ID :(
can it be added in the future ?

Comment 5

[Berend Cornelius]

Comment on attachment 350367 [details] [diff] [review]
Fix v1

r=berend. I think it's the right way to go to query the "checked" attribute of the command instead of the "selected" attribute of the tab. User interface elements are sort of transient over the time but commands are more likely to persist - that is one reason why we use them.

Comment 6

[Berend Cornelius]

pushed fix v1 to comm-central:

http://hg.mozilla.org/comm-central/rev/6a5ac370b3a6

I find the issue is fixed.

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".