Closed Bug 461278 Opened 16 years ago Closed 16 years ago

"ASSERTION: Uh, fix QI!" loading a bug list

Categories

(Core :: DOM: Core & HTML, defect, P1)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: jruderman, Assigned: peterv)

References

(
URL
)

Details

(Keywords: assertion, regression, testcase)

Attachments

(2 files)

testcase
158 bytes, text/html
Details
v1
776 bytes, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
Loading bug lists triggers:

###!!! ASSERTION: Uh, fix QI!: 'collection_qi == collection', file /Users/jruderman/central/dom/src/base/nsDOMClassInfo.cpp, line 7769

I think this is a regression from within the last day or two.
Attached file testcase — 

    
  
Keywords: testcase-wanted → testcase

    
    

    
  
Regression from bug 460512?

    
  
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
  
Assignee: nobody → peterv

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1
        — 
          — Splinter Review
      

    


  
Luckily nothing seriously wrong, just an annoying assertion that shouldn't hit. The object does implement nsIHTMLCollection but forgot to add to QI implementation

        Attachment #344452 -
        Flags: superreview?(bzbarsky)

        Attachment #344452 -
        Flags: review?(bzbarsky)

        Attachment #344452 -
        Flags: superreview?(bzbarsky)

        Attachment #344452 -
        Flags: superreview+

        Attachment #344452 -
        Flags: review?(bzbarsky)

        Attachment #344452 -
        Flags: review+

    
  
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2

    
  
Status: RESOLVED → REOPENED
Flags: blocking1.9.1+
Priority: -- → P1
Resolution: FIXED → ---

    
    

    
  
looks like this caused a giant spike in Mac Tp_RSS? blocker?
Flags: blocking1.9.1+ → blocking1.9.1?

    
    

    
  
Aye, ca'pn.

For those who like graphs: http://graphs.mozilla.org/graph.html#show=1431230
Flags: blocking1.9.1? → blocking1.9.1+

    
    

    
  
oh, nevermind. this is because they changed the way our tinderbox reports (bug 443979 )
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Flags: blocking1.9.1+
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: