The default bug view has changed. See this FAQ.

ASSERTION: Fix the caller, this type of node can never contain children.: 'parentTagEnum < NS_HTML_TAG_MAX'

RESOLVED FIXED in mozilla17

Status

()

Core
Editor
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: mats, Assigned: Ms2ger)

Tracking

({assertion, testcase})

Trunk
mozilla17
All
Linux
assertion, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Created attachment 344559 [details]
Testcase

STEPS TO REPRODUCE
1. load the attached testcase

ACTUAL RESULT
###!!! ASSERTION: Fix the caller, this type of node can never contain children.: 'parentTagEnum < NS_HTML_TAG_MAX', file /usr/moz/hg1/editor/libeditor/html/nsHTMLEditor.cpp, line 4183

Comment 1

9 years ago
The testcase in bug 382210 also triggers this assertion.

Comment 2

6 years ago
Still happens on trunk (not fixed in bug 414178).
(Assignee)

Comment 3

5 years ago
Created attachment 649204 [details] [diff] [review]
Patch v1

This is also hit in editing tests; possibly through the DocumentFragment case in nsEditor::CanContainTag.
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #649204 - Flags: review?(ehsan)
Comment on attachment 649204 [details] [diff] [review]
Patch v1

Review of attachment 649204 [details] [diff] [review]:
-----------------------------------------------------------------

I think the right fix to this is to OR the condition of the assertion with parentTagEnum == eHTMLTag_userdefined (assuming that that is what HTMLAtomTagToId returns).
Attachment #649204 - Flags: review?(ehsan) → review-
Comment on attachment 649204 [details] [diff] [review]
Patch v1

Ms2ger tells me that CanContain already asserts what I asked for here!
Attachment #649204 - Flags: review- → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/753b39a6e957
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.