461511 - If 'Directory Server' is enabled it is not possible to add more then one attendees at once

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- go to Prefrences/Composition/Addressing
- check 'Directory Server'
- create a new event
- open the attendees dialog
- try to invite more than one attendees

RESULT:
=======

- it's not possible to add more then one attendee without closing the dialog

EXPECTED RESULT:
================

- it should be possible to add more than one attendee

REPRODUCIBLE:
=============

- always

Comment 1

[Mark Banner (:standard8)]

Assuming this is the code I think it is (LDAP directory servers) that has been copy & pasted from MsgComposeCommands.js then before doing much work on it, it would be better to wait for my work on bug 452232 which is intending to greatly simplify the code required for LDAP autocomplete.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

I could not reproduce this issue with the latest nightlies. bug 452232 will unfortunately not block tb3.

Comment 3

[Mark Banner (:standard8)]

Attachment: [checked in] Partial Patch

This partially fixes the problem - input.syncSessions is undefined because we're not replacing the dummy element early enough, and hence the elements aren't connected right.

There are still significant issues with LDAP with this patch, and which seem to stop shutdown working correctly as well. My only thought is that the LDAP sessions aren't quite being handled correctly, and comparison of the xml file with the existing LDAP setup code may help.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 359248 [details] [diff] [review]
[checked in] Partial Patch

If this patch improves the situation, I'm fine with that. Do you think fixing the attendees dialog to work correctly with ldap is something feasible for 1.0 (i.e amount of work vs amount of improvement) ?

Comment 5

[Simon Paquet [:sipaq]]

Mark, can you please check this in?

Comment 6

[Mark Banner (:standard8)]

I'll check this in once the tree reopens - I don't want to push now as we are in the critical stage.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 359248 [details] [diff] [review]
[checked in] Partial Patch

Checked in: http://hg.mozilla.org/comm-central/rev/7e44a77f1892

Leaving open for now as it doesn't fix the problem fully.

Comment 8

[Stefan Sitter [:ssitter]]

Seems the checkin for this bug fixed Bug 459905 too. Thanks!

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

So, what exactly is left from this bug? Is the bug summary still valid? Do we really need to fix this for 1.0 ?

Comment 10

[Daniel Boelzle [:dbo]]

I can still confirm this issue, and can only auto-complete an attendee once. IMHO this is an important feature and used quite often, thus we shouldn't release without fixing it.

Comment 11

[Aaron Sierra]

Attachment: many user LDAP auto-complete patch

I've attached a proposed patch to fix the other half of this bug (more than one invitee auto-completion). I agree with Daniel that this is an important issue. I understand that there may be work on implementing this through some new way, but for the time being it would be great to see the current implementation work as needed.

Comment 12

[Martin Schröder [:mschroeder]]

Comment on attachment 421171 [details] [diff] [review]
many user LDAP auto-complete patch

Pushing in Philipp's review queue to get some feedback for Aaron.

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 421171 [details] [diff] [review]
many user LDAP auto-complete patch

Aaron, sorry for the delay. The patch works as expected, except for an error message alert on shutdown. This is fixed by forcing a garbage collection on unload. I've added this to the patch and will check in soon.

There were also a few places with tabs instead of spaces, I've also fixed this.

r=philipp

Comment 14

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/60cd0ff902e7>
-> FIXED