461512 - nsCSSColorUtils doesn't support alpha color (border color is always solid color if the border-style is groove, ridge, inset, outset)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

nsCSSColorUtils doesn't support alpha color. Therefore, the border color is always drawn by solid color if border-style is ridge, groove, inset or outset.

The attached patch also removes NS_Get3DColor and nsCSSRendering::TransformColor. Because they are not used.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: reftest

reftest for this bug. However, I cannot find to test dotted case. The dots of corners are overlapped, therefore, they are mismatch in this test.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0.1

fix some white spaces.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 344737 [details] [diff] [review]
Patch v1.0.1

Remove reftest-wait from your tests. It shouldn't be needed.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0.2 (for checked-in)

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

landed.

Comment 6

[Serge Gautherie (:sgautherie)]

{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1225159830.1225163390.11890.gz
Linux mozilla-central moz2-linux-slave07 dep unit test on 2008/10/27 19:10:30
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1225160355.1225163528.12126.gz
Linux mozilla-central moz2-linux-slave08 dep unit test on 2008/10/27 19:19:15
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1225160149.1225163577.12179.gz
WINNT 5.2 mozilla-central moz2-win32-slave07 dep unit test on 2008/10/27 19:15:49
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1225159936.1225163872.12911.gz
WINNT 5.2 mozilla-central moz2-win32-slave08 dep unit test on 2008/10/27 19:12:16

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1225160692.1225164712.14806.gz
Linux comm-central dep unit test on 2008/10/27 19:24:52
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1225160128.1225164532.14469.gz
Win2k3 comm-central dep unit test on 2008/10/27 19:15:28
}
(NB: MacOSX boxes haven't cycled yet.)

http://hg.mozilla.org/mozilla-central/rev/e94041498958
Disable failing new test [...]

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Than you, I'll check the cause.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: result of test

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: reference of the test

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The colors of result (rgba(10%, 20%, 30%, 0.5)):
  normal color:  #8c99a6 (rgb(140, 153, 166))
  lighter color: #dce0e4 (rgb(220, 224, 228))
  darker color:  #878e95 (rgb(135, 142, 149))

The colors of ref (rgb(10%, 20%, 30%) and parent's opacity: 0.5):
  normal color:  #8d99a6 (rgb(141, 153, 166))
  lighter color: #dde0e4 (rgb(221, 224, 228))
  darker color:  #878e95 (rgb(135, 142, 149))

The R values of normal and lighter are different. Is this a gfx bug of alpha rendering? Or is the idea of my test wrong?

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

roc, dbaron:

Do you have idea for comment 10? The colors of rgba(xx, xx, xx, 0.5) and (rgb(xx, xx, xx) + opacity: 0.5) are different, but I'm not sure the cause...

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I guess it's a rounding error somewhere.

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Fix the orange

Sorry for the delay.

This new test passes on tryserver.

But this fails to test the corners which are joined different colors. For avoiding the failure, this covers white background div boxes to the corners. However, it's enough for the testing of this bug because this bug caused the color computation, not the actual rendering code.

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/mozilla-central/rev/39e01c512c83