461610 - Bookmark drag and drop is canceled when dragging over another row in search results

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Ilya Sherman]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en; rv:1.9.0.4pre) Gecko/2008101818 Camino/2.0a1 (like Firefox/3.0.4pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en; rv:1.9.0.4pre) Gecko/2008101818 Camino/2.0a1 (like Firefox/3.0.4pre)

If you search for bookmarks, the first search result can be drag&dropped, but the rest cannot.

Reproducible: Always

Steps to Reproduce:
1. Open bookmarks manager
2. Search for something with multiple results
3. Try to drag a result other than the first one to, e.g., the URL bar
Actual Results:  
Bookmark starts to drag for a few pixels, but then jumps back.

Expected Results:  
Bookmark drags

Comment 1

[Stuart Morgan]

Tweaking summary; any bookmark can be dragged, but only until it crosses another row. If you drag out sideways first, any row works fine.

I'm not confirming because I thought we had a bug about weird behavior in the search results, but I'm not seeing it.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

10/25/08 12:34:28 AM Camino[2937] Error *** -[NSCFArray isSmartFolder]: unrecognized selector sent to instance 0x5e5ebf0 
10/25/08 12:34:28 AM Camino[2937] Warning *** Canceling drag because exception 'NSInvalidArgumentException' (reason '*** -[NSCFArray isSmartFolder]: unrecognized selector sent to instance 0x5e5ebf0') was raised during a dragging session

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> I'm not confirming because I thought we had a bug about weird behavior in the
> search results, but I'm not seeing it.

There was one where you couldn't do something with the first item in the search results (because we thought it was the folder), which I can't find but am sure we've fixed.  There was also bug 283615 and bug 294237.

Oddly enough, dragging works fine in 1.6.4 on 10.3.9 when there's no tab bar, whereas it's broken entirely in 1.6.4 (and 2.0a1) on 10.5.5.  I sorta thought this used to work, too, but quick testing shows not recently.

Comment 4

[Stuart Morgan]

I may well have been thinking of bug 283615; let's go ahead and confirm (thanks for searching)

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Thanks to murph teaching me the new way to break on exceptions on 10.5, I can tell that we're throwing the exception in BookmarkViewController here (1494):

> 1492   // if the proposed item's parent is a smart folder, deny the drop
> 1493   BookmarkFolder* parent = (item) ? item : [self itemTreeRootContainer];
> 1494   if ([parent isSmartFolder])
> 1495     return NSDragOperationNone;

Comment 6

[Chris Lawson (gone)]

Hrm. Why doesn't a BookmarkFolder* respond to |isSmartFolder|, potentially?

Comment 7

[Stuart Morgan]

Attachment: fix

Handle drop validation in search mode.

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 344785 [details] [diff] [review]
fix

sr=pink

Comment 9

[Stuart Morgan]

Landed on CVS trunk.