461637 - Error "ib is undefined" shows in the error console when you drag over the Bookmarks toolbar.

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.4pre) Gecko/2008102405 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081024 Minefield/3.1b2pre

When you drag a text over the Bookmarks toolbar.
following error shows in the error console.

Error: ib is undefined
Source File: chrome://browser/content/places/toolbar.xml
Line: 984




Reproducible: Always

Steps to Reproduce:
1.Set javascript.options.showInConsole to true
2.Select a text in contentarea.
3.Drag to the Bookmarks Toolbar
Actual Results:  
Error shows in the error console.

Expected Results:  
No error

      <handler event="dragover"><![CDATA[
        // Cache the dataTransfer
        var dt = PlacesControllerDragHelper.currentDataTransfer =
                 event.dataTransfer;

        var ip = this.insertionPoint;
        if (!ip || !PlacesControllerDragHelper.canDrop(ip)) {
>          ib.removeAttribute("dragging");
          return;
        }

Ib is not defined. 
This is a regression of Bug 458233

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch

a simple var definition move

Comment 2

[Marco Bonardo [:mak]]

fixed with patch in bug 225680

Comment 3

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Shiretoko/3.1b3pre