Closed
Bug 46173
Opened 25 years ago
Closed 25 years ago
mimetpfl fails to detect end of tags.
Categories
(MailNews Core :: MIME, defect, P3)
MailNews Core
MIME
Tracking
(Not tracked)
RESOLVED
FIXED
M17
People
(Reporter: bratell, Assigned: bratell)
Details
Attachments
(1 file)
4.99 KB,
patch
|
Details | Diff | Splinter Review |
There are code in mimetpfl to detect when a tag starts, but there's no code to
detect where it ends making the full line being treated like being inside a tag
which prevents SPACE -> -conversion, which causes multiple consecutive
whitespace to collapse.
Assignee | ||
Comment 1•25 years ago
|
||
Fixed this (and a glitch in bug 39728). Also factored out some duplicated code.
There are more code that are duplicated for the flowed and fixed cases, but that
will have to wait.
Status: NEW → ASSIGNED
Whiteboard: Fix exists. Needing review and approval.
Assignee | ||
Comment 2•25 years ago
|
||
Assignee | ||
Comment 3•25 years ago
|
||
Rich, could you review this? What I did was to keep track of if we are inside a
tag or not. There are also some code to detect if we are inside a quote inside a
tag so that we don't think the tag has ended when it hasn't. For instance in
<a href="hjh:>>>" we are still in tag>.
The fix for bug 39728 is to move the initializing of a variable outside the loop
so that it doesn't get reset every iteration.
Assignee | ||
Updated•25 years ago
|
Target Milestone: --- → M17
Comment 4•25 years ago
|
||
Looks good to me - r: rhp.
Assignee | ||
Comment 5•25 years ago
|
||
Assignee | ||
Comment 6•25 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Whiteboard: Fix exists. Needing review and approval.
Updated•20 years ago
|
Product: MailNews → Core
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•