windows mobile minor cleanup of media

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dougt, Assigned: blassey)

Tracking

({fixed1.9.1})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

9 years ago
we have reduce our dependency on many of the functions and defines in a windows mobile porting library (wince shunt).
(Reporter)

Comment 1

9 years ago
Created attachment 344977 [details] [diff] [review]
patch v.1
(Reporter)

Comment 2

9 years ago
Created attachment 346495 [details] [diff] [review]
patch v.2
Attachment #344977 - Attachment is obsolete: true
(Reporter)

Comment 3

9 years ago
windows mobile doesn't have stat().  Is there anything else we can do here Chris?
(Reporter)

Comment 4

9 years ago
Comment on attachment 346495 [details] [diff] [review]
patch v.2

chris, any ideas on what we can do here?
Attachment #346495 - Flags: review?(chris.double)

Comment 5

9 years ago
All it needs to do is find the length of the file. Can you do this with WINCE api calls?
(Reporter)

Comment 6

9 years ago
Created attachment 348924 [details] [diff] [review]
patch v.3

how is something like this?  (not tested)
Attachment #346495 - Attachment is obsolete: true
Attachment #348924 - Flags: review?(chris.double)
Attachment #346495 - Flags: review?(chris.double)
(Reporter)

Comment 7

9 years ago
chris, do you have any test cases I can run this through?

Comment 8

9 years ago
+    int current = ftell(oggz->file, 0, SEEK_CUR);

'current' needs to be a 'long' since that's what ftell returns. We'll need to #ifdef WINCE for this since the 'ftell' implementation loses data (fstat provides access to a 64bit size on systems that support that).

Comment 9

9 years ago
The seeking code should hit this so if you run the video mochitests they'll fail if this doesn't work.
(Reporter)

Comment 10

9 years ago
Created attachment 355837 [details] [diff] [review]
patch v.4

this compiles (yeah, a nice attribute of a patch), and passes mochitests (another nice attribute)
Attachment #348924 - Attachment is obsolete: true
Attachment #355837 - Flags: review?(chris.double)
Attachment #348924 - Flags: review?(chris.double)
chris, review ping?

Comment 12

9 years ago
Comment on attachment 355837 [details] [diff] [review]
patch v.4

I think the changes to oggz_offset_end should be wrapped in a #if for WINCE, and leave the existing code so that it runs as normal on other platforms.

A patch with these changes should also be added to the media/liboggz directory with update.sh modified to apply the patch so it doesn't get lost when I update to newer liboggz versions.

The README_MOZILLA will also need to be updated to refer to this bug and the patch. See the way the other patches are handled in those files.
Created attachment 358323 [details] [diff] [review]
patch v.5
Assignee: doug.turner → bugmail
Attachment #355837 - Attachment is obsolete: true
Attachment #358323 - Flags: review?
Attachment #355837 - Flags: review?(chris.double)

Updated

9 years ago
Attachment #358323 - Flags: review? → review+
http://hg.mozilla.org/mozilla-central/rev/59a7078453b0
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Attachment #358323 - Flags: approval1.9.1?
Attachment #358323 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 358323 [details] [diff] [review]
patch v.5

a191=beltzner
pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7df29ad7d757
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.