461847 - bzlib.c windows mobile does not support fileno

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Doug Turner (:dougt)]

window mobile does not have a fileno function.  This works around this problem.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Benjamin Smedberg]

Comment on attachment 344981 [details] [diff] [review]
patch v.1

Is this filed upstream? We use stock libbz2.

Comment 3

[Doug Turner (:dougt)]

sent mail to owners.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Doug, any update?

Comment 5

[Doug Turner (:dougt)]

I spoke to Julian Seward -- the current maintainer of libbz2.  

There is no specific schedule when libbz2 will be release.  The date floated was the first half of next year -- maybe sooner if there is a security flaw or something like that.

We should probably apply our changes locally, and wait for him to upstream this change.

Comment 6

[Doug Turner (:dougt)]

btw,

we should make this patch read:

&& ! defined(WINCE)

instead of 

&& !WINCE

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 344981 [details] [diff] [review]
patch v.1

brad, can you review, plz

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 344981 [details] [diff] [review]
patch v.1

windows ce also doesn't support setmode, correct?

If windows ce does support setmode, it may be better to just cast the FILE* to file descriptor that it is.

Comment 9

[Doug Turner (:dougt)]

changeset:   22813:28155683625d
tag:         tip
user:        Doug Turner <[e-mail]>
date:        Mon Dec 15 09:55:29 2008 -0800
summary:     Bug 461847 - Windows Mobile build bustage in BZ2.  Patch forwarded to bz2 owner, local change reviewed by blassey/bsmedberg