Closed Bug 461848 Opened 17 years ago Closed 17 years ago

libjar wince cleanup

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

patch v.2
607 bytes, patch
dveditz
: review+
dveditz
: superreview+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
io.h doesn't exists on windows mobile remove does not exist on windows mobile
Attached patch patch v.1 (obsolete) — — Splinter Review
Assignee: nobody → doug.turner
Attached patch patch v.2 — — Splinter Review
rename is not defined on windows mobile. we implemented it here in nsZipArchive.
Attachment #344982 - Attachment is obsolete: true
Attachment #346110 - Flags: superreview?
Attachment #346110 - Flags: review?(dveditz)
dan, need some review love here.
Comment on attachment 346110 [details] [diff] [review] patch v.2 r=dveditz Why are you building this standalone? I thought that was only used for the stub installer, which we don't use anymore.
Attachment #346110 - Flags: superreview?
Attachment #346110 - Flags: superreview+
Attachment #346110 - Flags: review?(dveditz)
Attachment #346110 - Flags: review+
dveditz it "just" gets build. MOZ_INSTALLER is defined. Should it not be on windows/windows mobile? If we are no longer building standalone, why is it in the tree?
http://hg.mozilla.org/mozilla-central/rev/bbd7d4a7f52c
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Attachment #346110 - Flags: approval1.9.1?
Comment on attachment 346110 [details] [diff] [review] patch v.2 a191=beltzner
Attachment #346110 - Flags: approval1.9.1? → approval1.9.1+
this landed on the 1.9.1 branch. adding keyword fixed1.9.1
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: