Closed
Bug 461849
Opened 17 years ago
Closed 16 years ago
icon decoder wince fixes
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: dougt, Assigned: dougt)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 1 obsolete file)
3.15 KB,
patch
|
pavlov
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
we removed much of the code in our wince shunt library. This patch allows icon decoder to build.
Assignee | ||
Comment 1•17 years ago
|
||
Assignee: nobody → doug.turner
Updated•17 years ago
|
Attachment #344983 -
Flags: review?(pavlov)
Comment 2•17 years ago
|
||
Comment on attachment 344983 [details] [diff] [review]
patch v.1
does it make sense to just not build the icon decoder rather than disabling it?
Assignee | ||
Comment 3•17 years ago
|
||
we could try that too!
Assignee | ||
Comment 4•17 years ago
|
||
disabled icon decoder.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
Comment 5•16 years ago
|
||
pav, review ping? If we're not going to fix icon decoder, can you explain why on the bug?
Assignee | ||
Comment 6•16 years ago
|
||
we simply disabled the icon decoder via configure. we could enable it, but not sure why we need the support on windows mobile.
Comment 7•16 years ago
|
||
Is this the cause of favicons not being displayed?
Status: RESOLVED → REOPENED
tracking-fennec: --- → ?
Resolution: WONTFIX → ---
Assignee | ||
Comment 8•16 years ago
|
||
same as before, just updated to the tip of m-c.
Without this patch, and simply disabling icon decoder support via configure, we do not display favicons.
Attachment #344983 -
Attachment is obsolete: true
Attachment #362916 -
Flags: review?(pavlov)
Attachment #344983 -
Flags: review?(pavlov)
Comment 10•16 years ago
|
||
Comment on attachment 362916 [details] [diff] [review]
patch v.2
please add some comments as to why we can't implement those functions.
Attachment #362916 -
Flags: review?(pavlov) → review+
Assignee | ||
Updated•16 years ago
|
Attachment #362916 -
Flags: approval1.9.1?
Assignee | ||
Comment 11•16 years ago
|
||
Assignee | ||
Comment 12•16 years ago
|
||
marking fixed. needs to land on 1.9.1
Status: REOPENED → RESOLVED
Closed: 17 years ago → 16 years ago
Resolution: --- → FIXED
Comment 13•16 years ago
|
||
Comment on attachment 362916 [details] [diff] [review]
patch v.2
a191=beltzner
Attachment #362916 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 14•16 years ago
|
||
Keywords: fixed1.9.1
Comment 15•16 years ago
|
||
I can view favicons on HTC Touch. verified FIXED on build:
Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
tracking-fennec: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•