4619 - UMR: nsInputStream::Get()

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P2)

Description

[Bruce Mitchener]

I constantly get this on Solaris 2.6, purify, gcc 2.7.2.3, etc. Current
build/pulls.  Happens during startup.

****  Purify instrumented ./apprunner.pure (pid 27193)  ****
UMR: Uninitialized memory read (3 times):
  * This is occurring while in:
        nsInputStream::get() [nsFileStream.cpp:47]
        nsHistoryDataSource::ReadOneHistoryFile(nsInputFileStream&,nsFileSpec)
[nsHistoryDataSource.cpp:635]
        nsHistoryDataSource::ReadHistory() [nsHistoryDataSource.cpp:616]
        nsHistoryDataSource::Init(const char*) [nsHistoryDataSource.cpp:471]
        ServiceImpl::GetDataSource(const char*,nsIRDFDataSource**)
[nsRDFService.cpp:857]
        nsGlobalHistory::Init() [nsGlobalHistory.cpp:101]
        nsAppShellService::Initialize() [nsAppShellService.cpp:167]
        main           [nsAppRunner.cpp:234]
        _start         [crt1.o]
  * Reading 1 byte from 0xefffefdf on the stack.
  * Address 0xefffefdf is local variable "c" in function nsInputStream::get().

Comment 1

[don]

Set target milestone to M4 and changed priority to P2.

Comment 2

[mcmullen]

The only way I can understand this is that it occurs when the eof is reached, and
the read operation did nothing to the buffer.

Accepting

Comment 3

[mcmullen]

Fix checked in.

Comment 4

[Bruce Mitchener]

Not getting this any longer. Thanks.

Comment 5

[Eli Goldberg]

Bulk moving to XPCOM, in preparation for removal of XP File Handling component. 
(XPFH has received two bugs in ~5 months, and is no longer in active use.)