Closed Bug 461902 Opened 13 years ago Closed 13 years ago

Remove obsoleted 'CompletionNotifier::cancel()'

Categories

(Toolkit :: Storage, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: sgautherie, Assigned: matthew.jay.hayward)

References

Details

(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b4])

Attachments

(1 file)

Whiteboard: [good first bug]
I saw this as low hanging fruit so I decided to try and fix it.

According to the linked bug this was just missed in another fix.  I ran a set of automated test cases and checked my build, but I'm not sure what the entire process is supposed to be.
Attachment #371343 - Flags: review?(sdwilsh)
Comment on attachment 371343 [details] [diff] [review]
Diff showing removal of virtual function Cancel
[Checkin: Comment 3 & 5]

r=sdwilsh

Thanks for doing this!
Attachment #371343 - Flags: review?(sdwilsh) → review+
Assignee: nobody → matthew.jay.hayward
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.2a1
Thanks for doing this work!

http://hg.mozilla.org/mozilla-central/rev/ad109d30c05e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Attachment #371343 - Flags: approval1.9.1?
Comment on attachment 371343 [details] [diff] [review]
Diff showing removal of virtual function Cancel
[Checkin: Comment 3 & 5]

a191=beltzner
Attachment #371343 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 371343 [details] [diff] [review]
Diff showing removal of virtual function Cancel
[Checkin: Comment 3 & 5]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e04fa2a6d6e5
Attachment #371343 - Attachment description: Diff showing removal of virtual function Cancel → Diff showing removal of virtual function Cancel [Checkin: Comment 3 & 5]
Keywords: fixed1.9.1
Whiteboard: [good first bug] → [fixed1.9.1b4]
You need to log in before you can comment on or make changes to this bug.