Closed
Bug 461902
Opened 16 years ago
Closed 16 years ago
Remove obsoleted 'CompletionNotifier::cancel()'
Categories
(Core :: SQLite and Embedded Database Bindings, defect)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sgautherie, Assigned: matthew.jay.hayward)
References
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b4])
Attachments
(1 file)
|
574 bytes,
patch
|
sdwilsh
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
|
||
Updated•16 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Comment 1•16 years ago
|
||
I saw this as low hanging fruit so I decided to try and fix it.
According to the linked bug this was just missed in another fix. I ran a set of automated test cases and checked my build, but I'm not sure what the entire process is supposed to be.
|
|
Assignee | |
Updated•16 years ago
|
Attachment #371343 -
Flags: review?(sdwilsh)
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 371343 [details] [diff] [review]
Diff showing removal of virtual function Cancel
[Checkin: Comment 3 & 5]
r=sdwilsh
Thanks for doing this!
Attachment #371343 -
Flags: review?(sdwilsh) → review+
|
|
||
Updated•16 years ago
|
Assignee: nobody → matthew.jay.hayward
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.2a1
|
|
||
Comment 3•16 years ago
|
||
Thanks for doing this work!
http://hg.mozilla.org/mozilla-central/rev/ad109d30c05e
|
Reporter | |
Updated•16 years ago
|
Attachment #371343 -
Flags: approval1.9.1?
|
||
Comment 4•16 years ago
|
||
Comment on attachment 371343 [details] [diff] [review]
Diff showing removal of virtual function Cancel
[Checkin: Comment 3 & 5]
a191=beltzner
Attachment #371343 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Reporter | |
Comment 5•16 years ago
|
||
Comment on attachment 371343 [details] [diff] [review]
Diff showing removal of virtual function Cancel
[Checkin: Comment 3 & 5]
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e04fa2a6d6e5
Attachment #371343 -
Attachment description: Diff showing removal of virtual function Cancel → Diff showing removal of virtual function Cancel
[Checkin: Comment 3 & 5]
|
|
Reporter | |
Updated•16 years ago
|
Keywords: fixed1.9.1
Whiteboard: [good first bug] → [fixed1.9.1b4]
|
||
Updated•3 months ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•