461938 - remove old suite typeaheadfind

Status: RESOLVED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Benjamin Smedberg]

From the landing of bug 461212 (now backed out):

e:/builds/slave/comm-central-win32/build/mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.cpp(2635) : error C2664: 'nsIFrameTraversal::NewFrameTraversal' : cannot convert parameter 1 from 'nsGetterAddRefs<T>' to 'nsIFrameEnumerator **'
        with
        [
            T=nsIBidirectionalEnumerator
        ]
        No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called

I didn't find this because it's not in the comm-central source code: you still pull this code from CVS. You need to either start using the toolkit typeaheadfind code, or put this code into the comm-central repository and make the matching changes from bug 461212 when it re-lands.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[Benjamin Smedberg]

Yeah, the patch is fine... we just can't land it in CVS, right?

Comment 3

[Serge Gautherie (:sgautherie)]

Replacing TAF is planned but not yet done.
Could we use some #ifdef in cvs for the time being ??

Comment 4

[Robert Kaiser]

I grow more and more in favor of just kicking out that old typeaheadfind without a real replacement. Maybe someone finally goes writing one when FAYT functionality disappears from the browser. :p

Comment 5

[Robert Kaiser]

Attachment: remove typeaheadfind from the build (checked in)

This patch removes typeaheadfind from the build "extensions" in SeaMonkey. See also http://home.kairo.at/blog/2008-10/the_neverending_typeaheadfind_story for reasoning why this might even be a good idea in the long run, but it's surely a fix for the bustage even if it kills a feature that probably is used by enough people (I'll surely feel the pain myself).

If we're staying with this for the long run, we need to kill references to this elsewhere as well as pulling the module from CVS in client.py.

Comment 6

[Justin Wood (:Callek)]

(In reply to comment #5)
> Created an attachment (id=345536) [details]
> If we're staying with this for the long run, we need to kill references to this
> elsewhere as well as pulling the module from CVS in client.py.

the idea, provided this does give us toolkit FAYT is good to me.

However I would rather land it as an across the board removal, client.py; build; packaging/installer; etc. Though of course, lets wait on Neil agreeing with the concept.

Comment 7

[Robert Kaiser]

Callek, I agree we should do the removal across the board ideally - in this case, just removing it from confvars.sh is a bustage fix so I'd rather get that in before thinking about anything else.

Comment 8

[Justin Wood (:Callek)]

(In reply to comment #7)
> Callek, I agree we should do the removal across the board ideally - in this
> case, just removing it from confvars.sh is a bustage fix so I'd rather get that
> in before thinking about anything else.

re: bustage fix, sure.

Comment 9

[Robert Kaiser]

Comment on attachment 345536 [details] [diff] [review]
remove typeaheadfind from the build (checked in)

Pushed this (or actually the version that doesn't have places in its context) as http://hg.mozilla.org/comm-central/rev/0a9821e4db57 - leaving the bug open for figuring out an actual solution (which could mean removing all references to typeaheadfind)

Comment 10

[Frank Wein [:mcsmurf]]

Not working on this.

Comment 11

[[e-mail]]

Attachment: WIP

I've only tested this in the browser, but you might already get some functionality in message windows. Note that I haven't attempted to implement autostart, nor do I watch for and cancel after scrolling or selection changes and the only pref that I currently honour is the timeout (which is hidden...)

Comment 12

[Robert Kaiser]

Neil, I think this work should actually go into bug 345526, and we should move this bug here to be about removing the suitetypeaheadfind.

BTW, our topcrash is in suitetypeaheadfind right now, due to people still having it in the tree -  I think adding it to removed-files.in should deal with the cases that happen due to Windows installer and auto-update.

Comment 13

[Robert Kaiser]

Attachment: kill old typeaheadfind from pull and packages [Checkin: Comment 15]

Here's a patch for removing the old typeaheadfind implementation from the pull and from packaging.

Neil, will you deal with the rest of things in http://mxr.mozilla.org/comm-central/search?find=%2Fsuite%2F&string=typeaheadfind in your work for bug 345526 (where I guess further WIPs will go)?

Comment 14

[[e-mail]]

Comment on attachment 346240 [details] [diff] [review]
kill old typeaheadfind from pull and packages
[Checkin: Comment 15]

Yes, I'll have to address those other hits.

Comment 15

[Robert Kaiser]

pushed the pull/package removal as http://hg.mozilla.org/comm-central/rev/13d566bc9176 - adjusting summary to reflect what we actually do/did here, bug 345526 is for the followup of a new implementation based on toolkit.

Comment 16

[Robert Kaiser]

Comment on attachment 345980 [details] [diff] [review]
WIP

obsoleting, new WIP is in bug 345526