Closed Bug 462034 Opened 16 years ago Closed 16 years ago

[FIX]Should consider .desktop files executable on Linux

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Version:
1.9.0 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: verified1.8.1.18, verified1.9.0.4, Whiteboard: [sg:moderate] keep private until bug 460425 fixed)

Attachments

(2 files)

Something like this, perhaps
2.11 KB, patch
benjamin
: review-
Details | Diff | Splinter Review
Like so
2.15 KB, patch
benjamin
: review+
samuel.sidler+old
: approval1.8.1.18+
samuel.sidler+old
: approval1.9.0.4+
Details | Diff | Splinter Review
See bug 460425 comment 21. We don't want to do this on trunk; just on branches, imo.
Benjamin, if you do get a chance to compile this on Linux, that would be great.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #345151 - Flags: review?(benjamin)
Summary: Should consider .desktop files executable on Linux → [FIX]Should consider .desktop files executable on Linux
Flags: wanted1.9.0.x+
Flags: wanted1.8.1.x+
Flags: blocking1.9.0.4+
Flags: blocking1.8.1.18+
Comment on attachment 345151 [details] [diff] [review] Something like this, perhaps As discussed in person, it would be better (and more correct in the BeOS/Solaris case) if the IsDesktopFile check were above the stat check
Attachment #345151 - Flags: review?(benjamin) → review-
Attached patch Like so — — Splinter Review
Attachment #345235 - Flags: review?(benjamin)
Attachment #345235 - Flags: review?(benjamin) → review+
Attachment #345235 - Flags: approval1.9.0.4?
Attachment #345235 - Flags: approval1.8.1.18?
Attachment #345235 - Flags: approval1.9.0.4?
Attachment #345235 - Flags: approval1.9.0.4+
Attachment #345235 - Flags: approval1.8.1.18?
Attachment #345235 - Flags: approval1.8.1.18+
Comment on attachment 345235 [details] [diff] [review] Like so Approved for 1.8.1.18 and 1.9.0.4. a=ss Please land ASAP on both branches.
Fixed on both branches.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: fixed1.8.1.18, fixed1.9.0.4
Resolution: --- → FIXED
Whiteboard: [sg:moderate
Whiteboard: [sg:moderate → [sg:moderate]
Verified using the testcase in bug 460425. Verified for 1.8.1.18 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.18pre) Gecko/2008102903 BonEcho/2.0.0.18pre. Verified for 1.9.0.4 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4pre) Gecko/2008102904 GranParadiso/3.0.4pre. I note that for 1.9.0.4, it doesn't list all of the plugins with the testcase (as it did for 3.0.3) but does still pull up the about:plugins page and list the libnullplugin.so plugin. The url of that page on my test box is jar:file:///home/mozilla/Desktop/3.0.4/chrome/toolkit.jar!/content/global/plugins.html. Is this result expected for 1.9.0.4?
Keywords: fixed1.8.1.18 → verified1.8.1.18
Yeah. Bug 460425 covers the rest of what needs to be done there.
Marking verified then. Thanks, Boris.
Keywords: fixed1.9.0.4 → verified1.9.0.4
Status: RESOLVED → VERIFIED
1.8 branches don't even support .desktop files on linux, do they?
That's correct, but just in case someone decides to backport support I figured it was good to land this simple change there.
not wanted on 1.8.0 branch.
Flags: wanted1.8.0.x-
Flags: blocking1.8.0.15-
Whiteboard: [sg:moderate] → [sg:moderate] keep private until bug 460425 fixed
A patch for *.desktop file support for Linux is in Bug 480907.
Group: core-security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: